From 79835b025698544fe69175f2a27c0eefc5f41947 Mon Sep 17 00:00:00 2001
From: catch <catch@35733.no-reply.drupal.org>
Date: Mon, 8 Jun 2020 13:23:56 +0100
Subject: [PATCH] Issue #3146567 by alexpott, pacproduct: Wrong key name in
"Missing required key (base_theme)" exception message
---
core/lib/Drupal/Core/Extension/ThemeExtensionList.php | 2 +-
.../Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/lib/Drupal/Core/Extension/ThemeExtensionList.php b/core/lib/Drupal/Core/Extension/ThemeExtensionList.php
index 0e7a60d30fd1..41ae9310bf4e 100644
--- a/core/lib/Drupal/Core/Extension/ThemeExtensionList.php
+++ b/core/lib/Drupal/Core/Extension/ThemeExtensionList.php
@@ -266,7 +266,7 @@ protected function createExtensionInfo(Extension $extension) {
$info = parent::createExtensionInfo($extension);
if (!isset($info['base theme'])) {
- throw new InfoParserException('Missing required key (base_theme) in ' . $extension->getExtensionPathname() . '/' . $extension->getExtensionFilename());
+ throw new InfoParserException(sprintf('Missing required key ("base theme") in %s/%s, see https://www.drupal.org/node/3066038', $extension->getExtensionPathname(), $extension->getExtensionFilename()));
}
// Remove the base theme when 'base theme: false' is set in a theme
diff --git a/core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php b/core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php
index 68c7cff2f5a8..9801f8b4e790 100644
--- a/core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php
@@ -75,7 +75,7 @@ public function testMissingBaseThemeException() {
->setInfoParser(new VfsInfoParser('vfs:/'));
$this->expectException(InfoParserException::class);
- $this->expectExceptionMessage('Missing required key (base_theme) in themes/test_missing_base_theme/test_missing_base_theme.theme/test_missing_base_theme.theme');
+ $this->expectExceptionMessage('Missing required key ("base theme") in themes/test_missing_base_theme/test_missing_base_theme.theme/test_missing_base_theme.theme, see https://www.drupal.org/node/3066038');
$this->themeInstaller->install(['test_missing_base_theme']);
}
--
GitLab