From 7eed52bfe764d0eb17646cc1a3232b711500d2a9 Mon Sep 17 00:00:00 2001
From: effulgentsia <alex.bronstein@acquia.com>
Date: Mon, 21 Oct 2019 12:23:35 -0700
Subject: [PATCH] Issue #3089168 by phenaproxima, bnjmnm: Remove or reduce
representational CSS classes in all Media Library tests
---
.../js/media_library.view.es6.js | 2 +-
.../media_library/js/media_library.view.js | 2 +-
.../media_library/src/Form/AddFormBase.php | 4 +-
.../CKEditorIntegrationTest.php | 4 +-
.../ContentModerationTest.php | 20 ++---
.../EmbeddedFormWidgetTest.php | 4 +-
.../FunctionalJavascript/MediaLibraryTest.php | 76 ++++++++-----------
.../FunctionalJavascript/TranslationsTest.php | 12 +--
8 files changed, 55 insertions(+), 69 deletions(-)
diff --git a/core/modules/media_library/js/media_library.view.es6.js b/core/modules/media_library/js/media_library.view.es6.js
index 19edce8bb953..9b28c72f482a 100644
--- a/core/modules/media_library/js/media_library.view.es6.js
+++ b/core/modules/media_library/js/media_library.view.es6.js
@@ -21,7 +21,7 @@
({ currentTarget }) => {
// Toggle all checkboxes.
const $checkboxes = $(currentTarget)
- .closest('.media-library-view')
+ .closest('.js-media-library-view')
.find('.js-media-library-item input[type="checkbox"]');
$checkboxes
.prop('checked', $(currentTarget).prop('checked'))
diff --git a/core/modules/media_library/js/media_library.view.js b/core/modules/media_library/js/media_library.view.js
index a8c335d50291..b3c21e9eb8cc 100644
--- a/core/modules/media_library/js/media_library.view.js
+++ b/core/modules/media_library/js/media_library.view.js
@@ -13,7 +13,7 @@
var $checkbox = $(Drupal.theme('checkbox')).on('click', function (_ref) {
var currentTarget = _ref.currentTarget;
- var $checkboxes = $(currentTarget).closest('.media-library-view').find('.js-media-library-item input[type="checkbox"]');
+ var $checkboxes = $(currentTarget).closest('.js-media-library-view').find('.js-media-library-item input[type="checkbox"]');
$checkboxes.prop('checked', $(currentTarget).prop('checked')).trigger('change');
var announcement = $(currentTarget).prop('checked') ? Drupal.t('All @count items selected', {
diff --git a/core/modules/media_library/src/Form/AddFormBase.php b/core/modules/media_library/src/Form/AddFormBase.php
index ec89426048d9..331fec0b84e0 100644
--- a/core/modules/media_library/src/Form/AddFormBase.php
+++ b/core/modules/media_library/src/Form/AddFormBase.php
@@ -629,13 +629,13 @@ public function updateFormCallback(array &$form, FormStateInterface $form_state)
break;
}
}
- $response->addCommand(new InvokeCommand(".media-library-add-form__media[data-media-library-added-delta=$delta_to_focus]", 'focus'));
+ $response->addCommand(new InvokeCommand("[data-media-library-added-delta=$delta_to_focus]", 'focus'));
}
}
// Update the form and shift focus to the added media items.
else {
$response->addCommand(new ReplaceCommand("#$wrapper_id", $form));
- $response->addCommand(new InvokeCommand('.media-library-add-form__added-media', 'focus'));
+ $response->addCommand(new InvokeCommand('.js-media-library-add-form-added-media', 'focus'));
}
return $response;
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php
index 7501df788889..50ee78b206f7 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php
@@ -220,9 +220,9 @@ public function testButton() {
}
$assert_session->pageTextContains('0 of 1 item selected');
- $assert_session->elementExists('css', '.media-library-item')->click();
+ $assert_session->elementExists('css', '.js-media-library-item')->click();
$assert_session->pageTextContains('1 of 1 item selected');
- $assert_session->elementExists('css', 'button.media-library-select.button.button--primary')->click();
+ $assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Insert selected');
$this->assignNameToCkeditorIframe();
$this->getSession()->switchToIFrame('ckeditor');
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '.cke_widget_drupalmedia drupal-media .media', 2000));
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/ContentModerationTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/ContentModerationTest.php
index 3e7361d10334..dbedfcd620e2 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/ContentModerationTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/ContentModerationTest.php
@@ -247,27 +247,27 @@ public function testWidget() {
// All users should only be able to see published media items.
$this->drupalLogin($this->rootUser);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userAdmin);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewer);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewOwnUnpublished);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewAnyUnpublished);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
@@ -280,27 +280,27 @@ public function testWidget() {
$this->drupalLogin($this->rootUser);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userAdmin);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewer);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewOwnUnpublished);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
$this->drupalLogin($this->userViewAnyUnpublished);
$this->drupalGet('node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->assertWaitOnAjaxRequest();
$this->assertOnlyPublishedMedia();
}
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest.php
index b00a24b3c920..9ac5d0e3c80b 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/EmbeddedFormWidgetTest.php
@@ -122,8 +122,8 @@ public function testInsertionAndReselection($widget) {
$page->fillField('Alternative text', $this->randomString());
$assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Save and insert');
$first_item_locator = "(//div[@data-drupal-selector='edit-media-image-field-selection-0'])[1]";
- $this->assertTrue($assert_session->waitForElementVisible('xpath', $first_item_locator));
- $assert_session->elementExists('css', '.media-library-item__remove')->click();
+ $this->assertTrue($first_item = $assert_session->waitForElementVisible('xpath', $first_item_locator));
+ $first_item->pressButton('Remove');
$assert_session->waitForElementRemoved('xpath', $first_item_locator);
$page->waitFor(10, function () use ($wrapper) {
return $wrapper->hasButton('Add media');
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/MediaLibraryTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/MediaLibraryTest.php
index ab818ba2f20d..5f9fb1df3b8f 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/MediaLibraryTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/MediaLibraryTest.php
@@ -485,7 +485,7 @@ public function testWidget() {
// the selected item.
$this->selectMediaItem(0);
$assert_session->hiddenFieldValueEquals('media-library-modal-selection', '4');
- $assert_session->elementTextContains('css', '.media-library-selected-count', '1 of 1 item selected');
+ $this->assertSelectedMediaCount('1 of 1 item selected');
$assert_session->elementNotExists('css', '.js-media-library-menu');
$assert_session->elementExists('css', '.ui-dialog-titlebar-close')->click();
@@ -559,11 +559,6 @@ public function testWidget() {
// Assert the focus is set back on the open button of the media field.
$this->assertJsCondition('jQuery("#field_twin_media-media-library-wrapper .js-media-library-open-button").is(":focus")');
- // Assert the weight field can be focused via a mouse click.
- $assert_session->elementExists('named', ['button', 'Show media item weights'])->click();
- $assert_session->elementExists('css', '#field_twin_media-media-library-wrapper .media-library-item__weight')->click();
- $assert_session->elementExists('css', '#field_twin_media-media-library-wrapper .js-media-library-widget-toggle-weight')->click();
-
// Assert that we can toggle the visibility of the weight inputs.
$wrapper = $assert_session->elementExists('css', '.field--name-field-twin-media');
$wrapper->pressButton('Show media item weights');
@@ -819,8 +814,6 @@ public function testWidgetViews() {
$this->drupalGet('node/add/basic_page');
- // Assert the media library contains header links to switch between the grid
- // and table display.
$this->openMediaLibraryForField('field_unlimited_media');
// Assert the 'Apply filter' button is not moved to the button pane.
@@ -829,13 +822,13 @@ public function testWidgetViews() {
$assert_session->buttonNotExists('Apply filters', $button_pane);
// Assert the pager works as expected.
- $assert_session->elementTextContains('css', '.view-media-library .pager__item.is-active', 'Page 1');
+ $assert_session->elementTextContains('css', '.js-media-library-view .pager__item.is-active', 'Page 1');
$this->assertCount(24, $this->getCheckboxes());
$page->clickLink('Next page');
- $this->waitForElementTextContains('.view-media-library .pager__item.is-active', 'Page 2');
+ $this->waitForElementTextContains('.js-media-library-view .pager__item.is-active', 'Page 2');
$this->assertCount(1, $this->getCheckboxes());
$page->clickLink('Previous page');
- $this->waitForElementTextContains('.view-media-library .pager__item.is-active', 'Page 1');
+ $this->waitForElementTextContains('.js-media-library-view .pager__item.is-active', 'Page 1');
$this->assertCount(24, $this->getCheckboxes());
$this->switchToMediaLibraryTable();
@@ -878,7 +871,6 @@ public function testWidgetViews() {
*/
public function testWidgetAnonymous() {
$assert_session = $this->assertSession();
- $page = $this->getSession()->getPage();
$this->drupalLogout();
@@ -952,7 +944,6 @@ public function testWidgetUpload() {
// Visit a node create page and open the media library.
$this->drupalGet('node/add/basic_page');
$this->openMediaLibraryForField('field_twin_media');
- $assert_session->pageTextContains('Add or select media');
// Assert the upload form is not visible for default tab type_three without
// the proper permissions.
@@ -1042,7 +1033,6 @@ public function testWidgetUpload() {
$this->waitForNoText($png_image->filename);
$this->openMediaLibraryForField('field_twin_media');
- $assert_session->pageTextContains('Add or select media');
$this->switchToMediaType('Three');
$png_uri_2 = $file_system->copy($png_image->uri, 'public://');
$this->addMediaFileToField('Add files', $this->container->get('file_system')->realpath($png_uri_2));
@@ -1165,17 +1155,16 @@ public function testWidgetUpload() {
$this->addMediaFileToField('Add files', $this->container->get('file_system')->realpath($png_image->uri));
// Assert the media item fields are shown and the vertical tabs are no
// longer shown.
+ $this->waitForFieldExists('Alternative text');
$this->assertMediaAdded();
// Press the 'Remove button' and assert the user is sent back to the media
// library.
- $assert_session->elementExists('css', '.media-library-add-form__remove-button')->click();
+ $page->pressButton('media-0-remove-button');
// Assert the remove message is shown.
$this->waitForText("The media item $png_image->filename has been removed.");
// Assert the focus is shifted to the first tabbable element of the add
// form, which should be the source field.
- $this->assertJsCondition('jQuery("#media-library-add-form-wrapper :tabbable").is(":focus")');
- $assert_session->elementNotExists('css', '.media-library-add-form__fields');
- $assert_session->elementExists('css', '.js-media-library-menu');
+ $this->assertNoMediaAdded();
$assert_session->elementExists('css', '.ui-dialog-titlebar-close')->click();
// Assert uploading multiple files.
@@ -1297,7 +1286,6 @@ public function testWidgetUploadAdvancedUi() {
// Visit a node create page and open the media library.
$this->drupalGet('node/add/basic_page');
$this->openMediaLibraryForField('field_twin_media');
- $assert_session->pageTextContains('Add or select media');
// Assert the upload form is not visible for default tab type_three without
// the proper permissions.
@@ -1346,7 +1334,7 @@ public function testWidgetUploadAdvancedUi() {
$assert_session->elementNotExists('css', '.media-library-add-form--without-input');
// We do not have a pre-selected items, so the container should not be added
// to the form.
- $assert_session->elementNotExists('css', '.media-library-add-form__selected-media');
+ $assert_session->elementNotExists('css', 'details summary:contains(Additional selected media)');
// Files are temporary until the form is saved.
$files = $file_storage->loadMultiple();
$file = array_pop($files);
@@ -1383,7 +1371,7 @@ public function testWidgetUploadAdvancedUi() {
$this->waitForText($png_image->filename);
// Remove the item.
- $assert_session->elementExists('css', '.media-library-item__remove')->click();
+ $assert_session->elementExists('css', '.field--name-field-twin-media')->pressButton('Remove');
$this->waitForNoText($png_image->filename);
$this->openMediaLibraryForField('field_twin_media');
@@ -1501,7 +1489,7 @@ public function testWidgetUploadAdvancedUi() {
// Close the details element so that clicking the Save and select works.
// @todo Fix dialog or test so this is not necessary to prevent random
// fails. https://www.drupal.org/project/drupal/issues/3055648
- $this->click('details.media-library-add-form__selected-media summary');
+ $selection_area->find('css', 'summary')->click();
$this->saveAnd('select');
$this->waitForText("Select $existing_media_name");
$media_items = Media::loadMultiple();
@@ -1523,14 +1511,10 @@ public function testWidgetUploadAdvancedUi() {
$this->assertMediaAdded();
// Press the 'Remove button' and assert the user is sent back to the media
// library.
- $assert_session->elementExists('css', '.media-library-add-form__remove-button')->click();
+ $page->pressButton('media-0-remove-button');
// Assert the remove message is shown.
$this->waitForText("The media item $png_image->filename has been removed.");
- // Assert the focus is shifted to the first tabbable element of the add
- // form, which should be the source field.
- $this->assertJsCondition('jQuery("#media-library-add-form-wrapper :tabbable").is(":focus")');
- $assert_session->elementNotExists('css', '.media-library-add-form__fields');
- $assert_session->elementExists('css', '.js-media-library-menu');
+ $this->assertNoMediaAdded();
$assert_session->elementExists('css', '.ui-dialog-titlebar-close')->click();
// Assert uploading multiple files.
@@ -1785,7 +1769,6 @@ public function testWidgetOEmbed() {
// Assert removing an added oEmbed media item before save works as expected.
$this->openMediaLibraryForField('field_unlimited_media');
- $assert_session->pageTextContains('Add or select media');
$this->switchToMediaType('Five');
$page->fillField('Add Type Five via URL', $youtube_url);
$page->pressButton('Add');
@@ -1794,14 +1777,10 @@ public function testWidgetOEmbed() {
$this->assertMediaAdded();
// Press the 'Remove button' and assert the user is sent back to the media
// library.
- $assert_session->elementExists('css', '.media-library-add-form__remove-button')->click();
+ $page->pressButton('media-0-remove-button');
// Assert the remove message is shown.
$this->waitForText("The media item $youtube_title has been removed.");
- // Assert the focus is shifted to the first tabbable element of the add
- // form, which should be the source field.
- $this->assertJsCondition('jQuery("#media-library-add-form-wrapper :tabbable").is(":focus")');
- $assert_session->elementNotExists('css', '.media-library-add-form__fields');
- $assert_session->elementExists('css', '.js-media-library-menu');
+ $this->assertNoMediaAdded();
}
/**
@@ -1953,7 +1932,6 @@ public function testWidgetOEmbedAdvancedUi() {
// Assert we can remove selected items from the selection area in the oEmbed
// form.
$this->openMediaLibraryForField('field_unlimited_media');
- $assert_session->pageTextContains('Add or select media');
$this->switchToMediaType('Five');
$checkbox = $page->findField("Select $vimeo_title");
$selected_item_id = $checkbox->getAttribute('value');
@@ -1995,14 +1973,10 @@ public function testWidgetOEmbedAdvancedUi() {
$this->assertMediaAdded();
// Press the 'Remove button' and assert the user is sent back to the media
// library.
- $assert_session->elementExists('css', '.media-library-add-form__remove-button')->click();
+ $page->pressButton('media-0-remove-button');
// Assert the remove message is shown.
$this->waitForText("The media item $youtube_title has been removed.");
- // Assert the focus is shifted to the first tabbable element of the add
- // form, which should be the source field.
- $this->assertJsCondition('jQuery("#media-library-add-form-wrapper :tabbable").is(":focus")');
- $assert_session->elementNotExists('css', '.media-library-add-form__fields');
- $assert_session->elementExists('css', '.js-media-library-menu');
+ $this->assertNoMediaAdded();
}
/**
@@ -2023,11 +1997,11 @@ public function testFieldUiIntegration() {
$page->selectFieldOption('new_storage_type', 'field_ui:entity_reference:media');
$this->assertTrue($assert_session->waitForField('label'));
$page->fillField('label', 'Shatner');
- $this->assertTrue($assert_session->waitForText('field_shatner'));
+ $this->waitForText('field_shatner');
$page->pressButton('Save and continue');
$page->pressButton('Save field settings');
$assert_session->pageTextNotContains('Undefined index: target_bundles');
- $page->checkField('settings[handler_settings][target_bundles][type_one]');
+ $this->waitForFieldExists('Type One')->check();
$this->assertElementExistsAfterWait('css', '[name="settings[handler_settings][target_bundles][type_one]"][checked="checked"]');
$page->checkField('settings[handler_settings][target_bundles][type_two]');
$this->assertElementExistsAfterWait('css', '[name="settings[handler_settings][target_bundles][type_two]"][checked="checked"]');
@@ -2143,6 +2117,7 @@ protected function switchToMediaType($type) {
/** @var \Behat\Mink\Element\NodeElement $link */
return $link->hasClass('active');
});
+ $this->assertNotEmpty($result);
// assertWaitOnAjaxRequest() required for input "id" attributes to
// consistently match their label's "for" attribute.
@@ -2265,6 +2240,13 @@ protected function openMediaLibraryForField($field_name, $after_open_selector =
->pressButton('Add media');
$this->waitForText('Add or select media');
+ // Assert that the grid display is visible and the links to toggle between
+ // the grid and table displays are present.
+ $this->assertMediaLibraryGrid();
+ $assert_session = $this->assertSession();
+ $assert_session->linkExists('Grid');
+ $assert_session->linkExists('Table');
+
return $this->assertElementExistsAfterWait('css', $after_open_selector);
}
@@ -2310,6 +2292,10 @@ protected function assertMediaAdded($index = 0) {
* Asserts that media was not added, i.e. due to a validation error.
*/
protected function assertNoMediaAdded() {
+ // Assert the focus is shifted to the first tabbable element of the add
+ // form, which should be the source field.
+ $this->assertJsCondition('jQuery("#media-library-add-form-wrapper :tabbable").is(":focus")');
+
$this->assertSession()
->elementNotExists('css', '[data-drupal-selector="edit-media-0-fields"]');
$this->getTypesMenu();
@@ -2415,7 +2401,7 @@ protected function assertMediaLibraryTable() {
*/
protected function assertSelectedMediaCount($text) {
$selected_count = $this->assertSession()
- ->elementExists('css', '.media-library-selected-count');
+ ->elementExists('css', '.js-media-library-selected-count');
$this->assertSame('status', $selected_count->getAttribute('role'));
$this->assertSame('polite', $selected_count->getAttribute('aria-live'));
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php
index 2696fca6318c..ff38ef2a3550 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/TranslationsTest.php
@@ -119,7 +119,7 @@ public function testMediaLibraryTranslations() {
// All translations should be shown in the administration overview,
// regardless of the interface language.
$this->drupalGet('nl/admin/content/media-grid');
- $assert_session->elementsCount('css', '.media-library-item', 6);
+ $assert_session->elementsCount('css', '.js-media-library-item', 6);
$media_items = $page->findAll('css', '.media-library-item__name');
$media_names = [];
foreach ($media_items as $media_item) {
@@ -129,7 +129,7 @@ public function testMediaLibraryTranslations() {
$this->assertSame(['Ardilla', 'Eekhoorn', 'Hert', 'Tejón', 'Vos', 'Zorro'], $media_names);
$this->drupalGet('es/admin/content/media-grid');
- $assert_session->elementsCount('css', '.media-library-item', 6);
+ $assert_session->elementsCount('css', '.js-media-library-item', 6);
$media_items = $page->findAll('css', '.media-library-item__name');
$media_names = [];
foreach ($media_items as $media_item) {
@@ -141,9 +141,9 @@ public function testMediaLibraryTranslations() {
// All media should only be shown once, and should be shown in the interface
// language.
$this->drupalGet('nl/node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->waitForText('Add or select media');
- $assert_session->elementsCount('css', '.media-library-item', 4);
+ $assert_session->elementsCount('css', '.js-media-library-item', 4);
$media_items = $page->findAll('css', '.media-library-item__name');
$media_names = [];
foreach ($media_items as $media_item) {
@@ -153,9 +153,9 @@ public function testMediaLibraryTranslations() {
$this->assertSame(['Eekhoorn', 'Hert', 'Tejón', 'Vos'], $media_names);
$this->drupalGet('es/node/add/article');
- $assert_session->elementExists('css', '.media-library-open-button[name^="field_media"]')->click();
+ $assert_session->elementExists('css', '.js-media-library-open-button[name^="field_media"]')->click();
$assert_session->waitForText('Add or select media');
- $assert_session->elementsCount('css', '.media-library-item', 4);
+ $assert_session->elementsCount('css', '.js-media-library-item', 4);
$media_items = $page->findAll('css', '.media-library-item__name');
$media_names = [];
foreach ($media_items as $media_item) {
--
GitLab