From 8d196a795038e76db34a58eba0a399ac2c6de7a3 Mon Sep 17 00:00:00 2001 From: Nathaniel Catchpole <catch@35733.no-reply.drupal.org> Date: Mon, 5 Oct 2015 12:00:42 +0100 Subject: [PATCH] Issue #2348729 by Manuel Garcia, joelpittet, akalata, subhojit777, Cottser, rpayanm: Convert theme_views_view_field to twig --- .../views/templates/views-view-field.html.twig | 6 +----- core/modules/views/views.module | 1 - core/modules/views/views.theme.inc | 13 ------------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/core/modules/views/templates/views-view-field.html.twig b/core/modules/views/templates/views-view-field.html.twig index a058548c514a..04a20ac5afe6 100644 --- a/core/modules/views/templates/views-view-field.html.twig +++ b/core/modules/views/templates/views-view-field.html.twig @@ -3,10 +3,6 @@ * @file * Default theme implementation for a single field in a view. * - * It is not actually used in default views, as this is registered as a theme - * function which has better performance. For single overrides, the template is - * perfectly okay. - * * Available variables: * - view: The view that the field belongs to. * - field: The field handler that can process the input. @@ -24,4 +20,4 @@ * @ingroup themeable */ #} -{{ output }} +{{ output -}} diff --git a/core/modules/views/views.module b/core/modules/views/views.module index dd1d196c90ff..30c92f3da455 100644 --- a/core/modules/views/views.module +++ b/core/modules/views/views.module @@ -133,7 +133,6 @@ function views_theme($existing, $type, $theme, $path) { // Default view themes $hooks['views_view_field'] = $base + array( 'variables' => array('view' => NULL, 'field' => NULL, 'row' => NULL), - 'function' => 'theme_views_view_field', ); $hooks['views_view_grouping'] = $base + array( 'variables' => array('view' => NULL, 'grouping' => NULL, 'grouping_level' => NULL, 'rows' => NULL, 'title' => NULL), diff --git a/core/modules/views/views.theme.inc b/core/modules/views/views.theme.inc index 45499fb0bbfd..8990584a9d54 100644 --- a/core/modules/views/views.theme.inc +++ b/core/modules/views/views.theme.inc @@ -208,19 +208,6 @@ function template_preprocess_views_view_grouping(&$variables) { $variables['content'] = $variables['view']->style_plugin->renderGroupingSets($variables['rows'], $variables['grouping_level']); } -/** - * Display a single views field. - * - * Interesting bits of info: - * $field->field_alias says what the raw value in $row will be. Reach it like - * this: @code { $row->{$field->field_alias} @endcode - * - * @ingroup themeable - */ -function theme_views_view_field($variables) { - return $variables['output']; -} - /** * Prepares variables for views field templates. * -- GitLab