From 18616ac0f5d86946a51b9755939d6b53a1cd5757 Mon Sep 17 00:00:00 2001
From: catch <catch@35733.no-reply.drupal.org>
Date: Mon, 13 Jun 2022 08:31:59 +0100
Subject: [PATCH] Issue #3285193 by Lendude, xjm: Temporarily skip random test
failures that hide real test failures, part 4
(cherry picked from commit dd16e9e8bb6952b32fa6c88011c0981b2495ea08)
---
.../tests/src/FunctionalJavascript/BlockFormMessagesTest.php | 1 +
.../tests/src/FunctionalJavascript/ContextualLinksTest.php | 1 +
.../tests/src/FunctionalJavascript/LayoutBuilderUiTest.php | 1 +
.../tests/src/FunctionalJavascript/MoveBlockFormTest.php | 2 ++
.../src/FunctionalJavascript/EntityReferenceWidgetTest.php | 1 +
.../src/FunctionalJavascript/SettingsTrayBlockFormTest.php | 1 +
6 files changed, 7 insertions(+)
diff --git a/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFormMessagesTest.php b/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFormMessagesTest.php
index 54e7e4e9b43c..166e10893be2 100644
--- a/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFormMessagesTest.php
+++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFormMessagesTest.php
@@ -62,6 +62,7 @@ public function testValidationMessage() {
$page->findLink('Add block')->click();
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-off-canvas .block-categories'));
$page->findLink('Powered by Drupal')->click();
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-off-canvas [name="settings[label]"]'));
$page->findField('Title')->setValue('');
$page->findButton('Add block')->click();
diff --git a/core/modules/layout_builder/tests/src/FunctionalJavascript/ContextualLinksTest.php b/core/modules/layout_builder/tests/src/FunctionalJavascript/ContextualLinksTest.php
index 948723323374..67252e387430 100644
--- a/core/modules/layout_builder/tests/src/FunctionalJavascript/ContextualLinksTest.php
+++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/ContextualLinksTest.php
@@ -127,6 +127,7 @@ protected function addBlock($block_name) {
* @internal
*/
protected function assertCorrectContextualLinksInUi(): void {
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$assert_session = $this->assertSession();
$page = $this->getSession()->getPage();
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '.block-views-blocktest-block-view-block-2'));
diff --git a/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php b/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php
index 77af692cc51a..f6dd1eab7878 100644
--- a/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php
+++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderUiTest.php
@@ -284,6 +284,7 @@ private function assertHighlightedElement(string $selector): void {
* Waits for the dialog to close and confirms no highlights are present.
*/
private function assertHighlightNotExists(): void {
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$assert_session = $this->assertSession();
$assert_session->assertNoElementAfterWait('css', '#drupal-off-canvas');
diff --git a/core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php b/core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php
index f7b302e7355b..79e5179c8c2e 100644
--- a/core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php
+++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/MoveBlockFormTest.php
@@ -63,6 +63,7 @@ protected function setUp(): void {
'.block-extra-field-blocknodebundle-with-section-fieldlinks',
'.block-field-blocknodebundle-with-section-fieldbody',
];
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$this->assertRegionBlocksOrder(0, 'content', $expected_block_order);
// Add a top section using the Two column layout.
@@ -114,6 +115,7 @@ public function testMoveBlock() {
// Move the body block into the first region above existing block.
$this->openBodyMoveForm(1, 'content', ['Body (current)', 'Links']);
$page->selectFieldOption('Region', '0:first');
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$this->assertBlockTable(['Powered by Drupal', 'Body (current)']);
$this->moveBlockWithKeyboard('up', 'Body', ['Body (current)*', 'Powered by Drupal']);
$page->pressButton('Move');
diff --git a/core/modules/media_library/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php b/core/modules/media_library/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php
index 31c00338290c..e7d5423fd3f0 100644
--- a/core/modules/media_library/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php
+++ b/core/modules/media_library/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php
@@ -225,6 +225,7 @@ public function testWidget() {
$session->getPage()->fillField('Name', 'Dog');
$session->getPage()->pressButton('Apply filters');
$this->waitForText('Dog');
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$this->waitForNoText('Bear');
$session->getPage()->fillField('Name', '');
$session->getPage()->pressButton('Apply filters');
diff --git a/core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php b/core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php
index 34f7a7869a9b..7a3c6a4a6ce0 100644
--- a/core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php
+++ b/core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php
@@ -241,6 +241,7 @@ public function testEditModeEnableDisable() {
case 'contextual_link':
$this->clickContextualLink($this->getBlockSelector($block), "Quick edit");
$this->waitForOffCanvasToOpen();
+ $this->markTestSkipped("Skipped temporarily for random fails.");
$this->assertEditModeEnabled();
break;
--
GitLab