From 9a0ebb87a2af1a0905d20c3153e4b18d82e35bc4 Mon Sep 17 00:00:00 2001 From: webchick <drupal@webchick.net> Date: Fri, 2 Aug 2019 08:46:48 -0700 Subject: [PATCH] Issue #3070604 by christinlepson, joachim, jhodgdon: badly named and documented parameter for FormBuilder::buildForm() --- core/lib/Drupal/Core/Form/FormBuilder.php | 4 ++-- core/lib/Drupal/Core/Form/FormBuilderInterface.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/lib/Drupal/Core/Form/FormBuilder.php b/core/lib/Drupal/Core/Form/FormBuilder.php index d6e3bebd0e8e..4d1dc27f7176 100644 --- a/core/lib/Drupal/Core/Form/FormBuilder.php +++ b/core/lib/Drupal/Core/Form/FormBuilder.php @@ -221,9 +221,9 @@ public function getForm($form_arg) { /** * {@inheritdoc} */ - public function buildForm($form_id, FormStateInterface &$form_state) { + public function buildForm($form_arg, FormStateInterface &$form_state) { // Ensure the form ID is prepared. - $form_id = $this->getFormId($form_id, $form_state); + $form_id = $this->getFormId($form_arg, $form_state); $request = $this->requestStack->getCurrentRequest(); diff --git a/core/lib/Drupal/Core/Form/FormBuilderInterface.php b/core/lib/Drupal/Core/Form/FormBuilderInterface.php index ca794379dbb5..6b6ed83046b0 100644 --- a/core/lib/Drupal/Core/Form/FormBuilderInterface.php +++ b/core/lib/Drupal/Core/Form/FormBuilderInterface.php @@ -68,7 +68,7 @@ public function getForm($form_arg); * previous page load. The form is then passed on for processing, validation, * and submission if there is proper input. * - * @param \Drupal\Core\Form\FormInterface|string $form_id + * @param \Drupal\Core\Form\FormInterface|string $form_arg * The value must be one of the following: * - The name of a class that implements \Drupal\Core\Form\FormInterface. * - An instance of a class that implements \Drupal\Core\Form\FormInterface. @@ -89,7 +89,7 @@ public function getForm($form_arg); * * @see self::redirectForm() */ - public function buildForm($form_id, FormStateInterface &$form_state); + public function buildForm($form_arg, FormStateInterface &$form_state); /** * Constructs a new $form from the information in $form_state. -- GitLab