From ba351b47cfb5290e192197abc7b35d00af34bc73 Mon Sep 17 00:00:00 2001 From: Alex Pott <alex.a.pott@googlemail.com> Date: Wed, 11 Mar 2020 13:33:59 +0000 Subject: [PATCH] Issue #3118998 by katherined, neelam_wadhwani, phenaproxima, effulgentsia: Remove null default for $memory_cache in entity storage handler constructors --- core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php | 4 ++-- core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php | 2 +- core/lib/Drupal/Core/Entity/EntityStorageBase.php | 2 +- core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php b/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php index 5569dd09893d..b944eea9f9b7 100644 --- a/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php +++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php @@ -105,10 +105,10 @@ class ConfigEntityStorage extends EntityStorageBase implements ConfigEntityStora * The UUID service. * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager * The language manager. - * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface|null $memory_cache + * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface $memory_cache * The memory cache backend. */ - public function __construct(EntityTypeInterface $entity_type, ConfigFactoryInterface $config_factory, UuidInterface $uuid_service, LanguageManagerInterface $language_manager, MemoryCacheInterface $memory_cache = NULL) { + public function __construct(EntityTypeInterface $entity_type, ConfigFactoryInterface $config_factory, UuidInterface $uuid_service, LanguageManagerInterface $language_manager, MemoryCacheInterface $memory_cache) { parent::__construct($entity_type, $memory_cache); $this->configFactory = $config_factory; diff --git a/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php b/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php index 833d22d3fa8b..0d039060c38e 100644 --- a/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php +++ b/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php @@ -60,7 +60,7 @@ abstract class ContentEntityStorageBase extends EntityStorageBase implements Con * The entity field manager. * @param \Drupal\Core\Cache\CacheBackendInterface $cache * The cache backend to be used. - * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface|null $memory_cache + * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface $memory_cache * The memory cache backend. * @param \Drupal\Core\Entity\EntityTypeBundleInfoInterface $entity_type_bundle_info * The entity type bundle info. diff --git a/core/lib/Drupal/Core/Entity/EntityStorageBase.php b/core/lib/Drupal/Core/Entity/EntityStorageBase.php index 63b0f6f8042a..8b78be167a9f 100644 --- a/core/lib/Drupal/Core/Entity/EntityStorageBase.php +++ b/core/lib/Drupal/Core/Entity/EntityStorageBase.php @@ -85,7 +85,7 @@ abstract class EntityStorageBase extends EntityHandlerBase implements EntityStor * * @param \Drupal\Core\Entity\EntityTypeInterface $entity_type * The entity type definition. - * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface|null $memory_cache + * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface $memory_cache * The memory cache. */ public function __construct(EntityTypeInterface $entity_type, MemoryCacheInterface $memory_cache) { diff --git a/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php index 044c0de64e18..696203a6c516 100644 --- a/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php +++ b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php @@ -170,7 +170,7 @@ public static function createInstance(ContainerInterface $container, EntityTypeI * The cache backend to be used. * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager * The language manager. - * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface|null $memory_cache + * @param \Drupal\Core\Cache\MemoryCache\MemoryCacheInterface $memory_cache * The memory cache backend to be used. * @param \Drupal\Core\Entity\EntityTypeBundleInfoInterface $entity_type_bundle_info * The entity type bundle info. -- GitLab