diff --git a/core/lib/Drupal/Core/Entity/EntityListBuilder.php b/core/lib/Drupal/Core/Entity/EntityListBuilder.php index c7843517be50e203c8dca5360ba79aa8c3bc24f4..3039c4f8eb04d6e7493071b5a9e7041d168a6f10 100644 --- a/core/lib/Drupal/Core/Entity/EntityListBuilder.php +++ b/core/lib/Drupal/Core/Entity/EntityListBuilder.php @@ -54,7 +54,7 @@ class EntityListBuilder extends EntityHandlerBase implements EntityListBuilderIn public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()) + $container->get('entity_type.manager')->getStorage($entity_type->id()) ); } diff --git a/core/modules/action/src/ActionListBuilder.php b/core/modules/action/src/ActionListBuilder.php index a5102d3596f26cc4eabc444ab739f369b4741ab6..f2d829c43a04384e4e5f3a639a89aa006415302f 100644 --- a/core/modules/action/src/ActionListBuilder.php +++ b/core/modules/action/src/ActionListBuilder.php @@ -51,7 +51,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('plugin.manager.action') ); } diff --git a/core/modules/block/src/BlockListBuilder.php b/core/modules/block/src/BlockListBuilder.php index 3884d27f21ea79f86aa4a4d8ff0d5bdbf1c151b4..be5ac8fcb4608b31226b6128ceb70e55f72581c3 100644 --- a/core/modules/block/src/BlockListBuilder.php +++ b/core/modules/block/src/BlockListBuilder.php @@ -90,7 +90,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('theme.manager'), $container->get('form_builder'), $container->get('messenger') diff --git a/core/modules/config_translation/src/Controller/ConfigTranslationBlockListBuilder.php b/core/modules/config_translation/src/Controller/ConfigTranslationBlockListBuilder.php index c226dfbd60a7ae9016e32d4c6183d2f3e9b7a26b..b6186aaf7b3767498a1cfe077b13c3239c934d5d 100644 --- a/core/modules/config_translation/src/Controller/ConfigTranslationBlockListBuilder.php +++ b/core/modules/config_translation/src/Controller/ConfigTranslationBlockListBuilder.php @@ -34,7 +34,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('theme_handler') ); } diff --git a/core/modules/content_moderation/src/ModeratedNodeListBuilder.php b/core/modules/content_moderation/src/ModeratedNodeListBuilder.php index 30b90f98cd4ba3f50297e8f5ebb7cd773ed222af..71beae24745bbb48c77a198e844b7a9920d3e1b2 100644 --- a/core/modules/content_moderation/src/ModeratedNodeListBuilder.php +++ b/core/modules/content_moderation/src/ModeratedNodeListBuilder.php @@ -54,12 +54,13 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter * {@inheritdoc} */ public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { + $entity_type_manager = $container->get('entity_type.manager'); return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $entity_type_manager->getStorage($entity_type->id()), $container->get('date.formatter'), $container->get('redirect.destination'), - $container->get('entity_type.manager') + $entity_type_manager ); } diff --git a/core/modules/field_ui/src/EntityDisplayModeListBuilder.php b/core/modules/field_ui/src/EntityDisplayModeListBuilder.php index cf44b8b78de6ef74c9622320288f15e8ebadc914..35a8b1cf6b220efbc073da8ae0fe9fcbf7a11b67 100644 --- a/core/modules/field_ui/src/EntityDisplayModeListBuilder.php +++ b/core/modules/field_ui/src/EntityDisplayModeListBuilder.php @@ -45,11 +45,11 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter * {@inheritdoc} */ public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { - $entity_manager = $container->get('entity.manager'); + $entity_type_manager = $container->get('entity_type.manager'); return new static( $entity_type, - $entity_manager->getStorage($entity_type->id()), - $entity_manager->getDefinitions() + $entity_type_manager->getStorage($entity_type->id()), + $entity_type_manager->getDefinitions() ); } diff --git a/core/modules/field_ui/src/FieldConfigListBuilder.php b/core/modules/field_ui/src/FieldConfigListBuilder.php index a6363aa0ee6e4ff9147bf709a2f82728b542d81d..8e0838d119d47c6ea22bc678c4656d193e259670 100644 --- a/core/modules/field_ui/src/FieldConfigListBuilder.php +++ b/core/modules/field_ui/src/FieldConfigListBuilder.php @@ -4,8 +4,10 @@ use Drupal\Component\Utility\Html; use Drupal\Core\Config\Entity\ConfigEntityListBuilder; +use Drupal\Core\DependencyInjection\DeprecatedServicePropertyTrait; +use Drupal\Core\Entity\EntityFieldManagerInterface; use Drupal\Core\Entity\EntityInterface; -use Drupal\Core\Entity\EntityManagerInterface; +use Drupal\Core\Entity\EntityTypeManagerInterface; use Drupal\Core\Entity\EntityTypeInterface; use Drupal\Core\Field\FieldTypePluginManagerInterface; use Drupal\Core\Url; @@ -16,6 +18,14 @@ * Provides lists of field config entities. */ class FieldConfigListBuilder extends ConfigEntityListBuilder { + use DeprecatedServicePropertyTrait; + + /** + * {@inheritdoc} + */ + protected $deprecatedProperties = [ + 'entityManager' => 'entity.manager', + ]; /** * The name of the entity type the listed fields are attached to. @@ -32,11 +42,11 @@ class FieldConfigListBuilder extends ConfigEntityListBuilder { protected $targetBundle; /** - * The entity manager. + * The entity type manager. * - * @var \Drupal\Core\Entity\EntityManagerInterface + * @var \Drupal\Core\Entity\EntityTypeManagerInterface */ - protected $entityManager; + protected $entityTypeManager; /** * The field type plugin manager. @@ -45,28 +55,47 @@ class FieldConfigListBuilder extends ConfigEntityListBuilder { */ protected $fieldTypeManager; + /** + * The entity field manager. + * + * @var \Drupal\Core\Entity\EntityFieldManagerInterface + */ + protected $entityFieldManager; + /** * Constructs a new class instance. * * @param \Drupal\Core\Entity\EntityTypeInterface $entity_type * The entity type definition. - * @param \Drupal\Core\Entity\EntityManagerInterface $entity_manager - * The entity manager. + * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager + * The entity type manager. * @param \Drupal\Core\Field\FieldTypePluginManagerInterface $field_type_manager - * The field type manager + * The field type manager. + * @param \Drupal\Core\Entity\EntityFieldManagerInterface|null $entity_field_manager + * The entity field manager. */ - public function __construct(EntityTypeInterface $entity_type, EntityManagerInterface $entity_manager, FieldTypePluginManagerInterface $field_type_manager) { - parent::__construct($entity_type, $entity_manager->getStorage($entity_type->id())); + public function __construct(EntityTypeInterface $entity_type, EntityTypeManagerInterface $entity_type_manager, FieldTypePluginManagerInterface $field_type_manager, EntityFieldManagerInterface $entity_field_manager = NULL) { + parent::__construct($entity_type, $entity_type_manager->getStorage($entity_type->id())); - $this->entityManager = $entity_manager; + $this->entityTypeManager = $entity_type_manager; $this->fieldTypeManager = $field_type_manager; + if (!$entity_field_manager) { + @trigger_error('Calling FieldConfigListBuilder::__construct() with the $entity_field_manager argument is supported in Drupal 8.7.0 and will be required before Drupal 9.0.0. See https://www.drupal.org/node/2549139.', E_USER_DEPRECATED); + $entity_field_manager = \Drupal::service('entity_field.manager'); + } + $this->entityFieldManager = $entity_field_manager; } /** * {@inheritdoc} */ public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { - return new static($entity_type, $container->get('entity.manager'), $container->get('plugin.manager.field.field_type')); + return new static( + $entity_type, + $container->get('entity_type.manager'), + $container->get('plugin.manager.field.field_type'), + $container->get('entity_field.manager') + ); } /** @@ -87,7 +116,7 @@ public function render($target_entity_type_id = NULL, $target_bundle = NULL) { * {@inheritdoc} */ public function load() { - $entities = array_filter($this->entityManager->getFieldDefinitions($this->targetEntityTypeId, $this->targetBundle), function ($field_definition) { + $entities = array_filter($this->entityFieldManager->getFieldDefinitions($this->targetEntityTypeId, $this->targetBundle), function ($field_definition) { return $field_definition instanceof FieldConfigInterface; }); @@ -120,7 +149,7 @@ public function buildRow(EntityInterface $field_config) { $field_storage = $field_config->getFieldStorageDefinition(); $route_parameters = [ 'field_config' => $field_config->id(), - ] + FieldUI::getRouteBundleParameter($this->entityManager->getDefinition($this->targetEntityTypeId), $this->targetBundle); + ] + FieldUI::getRouteBundleParameter($this->entityTypeManager->getDefinition($this->targetEntityTypeId), $this->targetBundle); $row = [ 'id' => Html::getClass($field_config->getName()), diff --git a/core/modules/field_ui/src/FieldStorageConfigListBuilder.php b/core/modules/field_ui/src/FieldStorageConfigListBuilder.php index 422c3b69d77efc660034f5de9e923e8668d5cf99..fd87b619a6e03c0163b796c69cdd0453f7762958 100644 --- a/core/modules/field_ui/src/FieldStorageConfigListBuilder.php +++ b/core/modules/field_ui/src/FieldStorageConfigListBuilder.php @@ -3,8 +3,9 @@ namespace Drupal\field_ui; use Drupal\Core\Config\Entity\ConfigEntityListBuilder; +use Drupal\Core\DependencyInjection\DeprecatedServicePropertyTrait; use Drupal\Core\Entity\EntityInterface; -use Drupal\Core\Entity\EntityManagerInterface; +use Drupal\Core\Entity\EntityTypeManagerInterface; use Drupal\Core\Entity\EntityTypeInterface; use Drupal\Core\Entity\EntityTypeBundleInfoInterface; use Drupal\Core\Field\FieldTypePluginManagerInterface; @@ -17,6 +18,14 @@ * @see field_ui_entity_info() */ class FieldStorageConfigListBuilder extends ConfigEntityListBuilder { + use DeprecatedServicePropertyTrait; + + /** + * {@inheritdoc} + */ + protected $deprecatedProperties = [ + 'entityManager' => 'entity.manager', + ]; /** * An array of information about field types. @@ -26,11 +35,11 @@ class FieldStorageConfigListBuilder extends ConfigEntityListBuilder { protected $fieldTypes; /** - * The entity manager. + * The entity type manager. * - * @var \Drupal\Core\Entity\EntityManagerInterface + * @var \Drupal\Core\Entity\EntityTypeManagerInterface */ - protected $entityManager; + protected $entityTypeManager; /** * An array of entity bundle information. @@ -51,15 +60,15 @@ class FieldStorageConfigListBuilder extends ConfigEntityListBuilder { * * @param \Drupal\Core\Entity\EntityTypeInterface $entity_type * The entity type definition. - * @param \Drupal\Core\Entity\EntityManagerInterface $entity_manager + * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager * The entity manager. * @param \Drupal\Core\Field\FieldTypePluginManagerInterface $field_type_manager * The 'field type' plugin manager. */ - public function __construct(EntityTypeInterface $entity_type, EntityManagerInterface $entity_manager, FieldTypePluginManagerInterface $field_type_manager, EntityTypeBundleInfoInterface $bundle_info_service) { - parent::__construct($entity_type, $entity_manager->getStorage($entity_type->id())); + public function __construct(EntityTypeInterface $entity_type, EntityTypeManagerInterface $entity_type_manager, FieldTypePluginManagerInterface $field_type_manager, EntityTypeBundleInfoInterface $bundle_info_service) { + parent::__construct($entity_type, $entity_type_manager->getStorage($entity_type->id())); - $this->entityManager = $entity_manager; + $this->entityTypeManager = $entity_type_manager; $this->bundles = $bundle_info_service->getAllBundleInfo(); $this->fieldTypeManager = $field_type_manager; $this->fieldTypes = $this->fieldTypeManager->getDefinitions(); @@ -71,7 +80,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityManagerInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager'), + $container->get('entity_type.manager'), $container->get('plugin.manager.field.field_type'), $container->get('entity_type.bundle.info') ); diff --git a/core/modules/filter/src/FilterFormatListBuilder.php b/core/modules/filter/src/FilterFormatListBuilder.php index f15474694d5aadc42d43b1b3f09fc12e6793c12d..d63ea6c9fc479b68a947a4f8045a988d5d67d149 100644 --- a/core/modules/filter/src/FilterFormatListBuilder.php +++ b/core/modules/filter/src/FilterFormatListBuilder.php @@ -62,7 +62,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('config.factory'), $container->get('messenger') ); diff --git a/core/modules/language/src/LanguageListBuilder.php b/core/modules/language/src/LanguageListBuilder.php index caf1d9187d43df182aa7737bc1b7ae9bf49ddb67..f736738669bdc9a20cf3713d9bc530a3d65d5267 100644 --- a/core/modules/language/src/LanguageListBuilder.php +++ b/core/modules/language/src/LanguageListBuilder.php @@ -51,7 +51,7 @@ class LanguageListBuilder extends DraggableListBuilder { public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('language_manager'), $container->get('config.factory'), $container->get('messenger') diff --git a/core/modules/media/src/MediaListBuilder.php b/core/modules/media/src/MediaListBuilder.php index 237129bbb02d46b0e103fc187b48e68849b65d62..0f57eac43e74d95c2c97a674d18c61f5ca69fd8a 100644 --- a/core/modules/media/src/MediaListBuilder.php +++ b/core/modules/media/src/MediaListBuilder.php @@ -62,12 +62,13 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter * {@inheritdoc} */ public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { + $entity_type_manager = $container->get('entity_type.manager'); return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $entity_type_manager->getStorage($entity_type->id()), $container->get('date.formatter'), $container->get('language_manager'), - $container->get('entity_type.manager')->getStorage('image_style') + $entity_type_manager->getStorage('image_style') ); } diff --git a/core/modules/node/src/NodeListBuilder.php b/core/modules/node/src/NodeListBuilder.php index 4cab89106630efe3254aae9da6462db155976fa6..22b900da876636c9e3d8be3a32d56a5708d86259 100644 --- a/core/modules/node/src/NodeListBuilder.php +++ b/core/modules/node/src/NodeListBuilder.php @@ -50,7 +50,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('date.formatter'), $container->get('redirect.destination') ); diff --git a/core/modules/search/src/SearchPageListBuilder.php b/core/modules/search/src/SearchPageListBuilder.php index bde195ec638edc3c33abbf7a773ad9bcfd9db971..b0382251b7d495a6f7f3426ce6ba84dc4a78cb2e 100644 --- a/core/modules/search/src/SearchPageListBuilder.php +++ b/core/modules/search/src/SearchPageListBuilder.php @@ -77,7 +77,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('plugin.manager.search'), $container->get('config.factory'), $container->get('messenger') diff --git a/core/modules/system/src/DateFormatListBuilder.php b/core/modules/system/src/DateFormatListBuilder.php index c0e2c366f0892564b9cc752819bf70999dfbb616..0c94a64197ae40d343e5c26a55497509ff04d83d 100644 --- a/core/modules/system/src/DateFormatListBuilder.php +++ b/core/modules/system/src/DateFormatListBuilder.php @@ -45,7 +45,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('date.formatter') ); } diff --git a/core/modules/user/src/RoleListBuilder.php b/core/modules/user/src/RoleListBuilder.php index 40ae5e4891bafc3166cd133dd48a1c015a2144ee..d864a550d02b09313abb353fbbf010da7d84ebc4 100644 --- a/core/modules/user/src/RoleListBuilder.php +++ b/core/modules/user/src/RoleListBuilder.php @@ -47,7 +47,7 @@ public function __construct(EntityTypeInterface $entityType, public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('messenger') ); } diff --git a/core/modules/user/src/UserListBuilder.php b/core/modules/user/src/UserListBuilder.php index 306d04609e76169126aa66cb96041a331fd43549..8c3cef90dfc4c4eba1c05b7bafcd7b1feaf80b9e 100644 --- a/core/modules/user/src/UserListBuilder.php +++ b/core/modules/user/src/UserListBuilder.php @@ -56,7 +56,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('date.formatter'), $container->get('redirect.destination') ); diff --git a/core/modules/views_ui/src/ViewListBuilder.php b/core/modules/views_ui/src/ViewListBuilder.php index a3e384098b487af4b2bd01aa6673ec3bd75a0b97..617275a1a689c6cbf4ae57b19eece6977f7200fd 100644 --- a/core/modules/views_ui/src/ViewListBuilder.php +++ b/core/modules/views_ui/src/ViewListBuilder.php @@ -36,7 +36,7 @@ class ViewListBuilder extends ConfigEntityListBuilder { public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('plugin.manager.views.display') ); } diff --git a/core/modules/workspaces/src/WorkspaceListBuilder.php b/core/modules/workspaces/src/WorkspaceListBuilder.php index 56ab1c5e43d37707748e547494bec76bf64626d7..360c1e89e143fe5264ab313bce67828e8cfcb52f 100644 --- a/core/modules/workspaces/src/WorkspaceListBuilder.php +++ b/core/modules/workspaces/src/WorkspaceListBuilder.php @@ -48,7 +48,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) { return new static( $entity_type, - $container->get('entity.manager')->getStorage($entity_type->id()), + $container->get('entity_type.manager')->getStorage($entity_type->id()), $container->get('workspaces.manager') ); }