Rename "Create content entity" events

Issue information

From user: jurgenhaas

Related to !277 (merged)

Contribution record

Fork management

Problem/Motivation

The event "Create content entity" (and similar ones) are used accidentally pretty often and lead to errors. This is because the wording suggests, that this will be triggered when the entity is being created, i.e. written to the database. However, that's not the case as it is already triggered when Node::create() is being called in PHP. That's very early in the process and the entity doesn't really exist at that time. At least not with all it's properties that would be called in an ECA model subsequently.

Proposed resolution

Let's change the labels for those events in \Drupal\eca_content\Plugin\ECA\Event\ContentEntityEvent::definitions. A proposal by @mherchel was "Programmatically create content entity" and we could add some extra warning to the description.

Edited by drupalbot
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information