Cater for deprecating SKIP_COMPOSER in D7 pipelines
Problem/Motivation
In #3414391: Define extra rule to jobs that have "needs: composer" the variable SKIP_COMPOSER was deprecated and we now run the Composer job whenever it is required, and not when it is not required. This change of behavior and the new 'deprecation warning' .pre job also needs to be implemented in the main-d7 template, so that the behavoir is consistent when running pipelines on Drupal 7
Steps to reproduce
Run a D7 pipeline with SKIP_COMPOSER: 1 and the pipeline fails to be built, with the error
Unable to create pipeline
'phpcs' job needs 'composer' job, but 'composer' is not in any previous stage
'phpunit' job needs 'composer' job, but 'composer' is not in any previous stage
Proposed resolution
The composer-base job has rule
if: '$SKIP_COMPOSER == "1"'
when:never
Change the check to
SKIP_PHPCS != 1 && SKIP_PHPUNIT != 1
when:never
Edited by drupalbot