Nuke the tangle

core/modules/node/node.module

@@ -493,32 +493,9 @@ function template_preprocess_node(&$variables) {
   $variables['node'] = $variables['elements']['#node'];
   /** @var \Drupal\node\NodeInterface $node */
   $node = $variables['node'];
-  $skip_custom_preprocessing = $node->getEntityType()->get('enable_base_field_custom_preprocess_skipping');
-
-  // Make created, uid and title fields available separately. Skip this custom
-  // preprocessing if the field display is configurable and skipping has been
-  // enabled.
-  // @todo https://www.drupal.org/project/drupal/issues/3015623
-  //   Eventually delete this code and matching template lines. Using
-  //   $variables['content'] is more flexible and consistent.
-  $submitted_configurable = $node->getFieldDefinition('created')->isDisplayConfigurable('view') || $node->getFieldDefinition('uid')->isDisplayConfigurable('view');
-  if (!$skip_custom_preprocessing || !$submitted_configurable) {
-    $variables['date'] = \Drupal::service('renderer')->render($variables['elements']['created']);
-    unset($variables['elements']['created']);
-    $variables['author_name'] = \Drupal::service('renderer')->render($variables['elements']['uid']);
-    unset($variables['elements']['uid']);
-  }
-
-  // If the title is configurable, then it will only be a child element if it is configured to not be hidden.
-  // Custom preprocess will be skipped if skipping is requested by flag, or title is configured to display normally not hide,
-  // or custom code has requested the field to be not configurable.
-  if (!$skip_custom_preprocessing && !isset($variables['elements']['title'] )) {
-    @trigger_error("Custom preprocessing for node titles in template_node_preprocess is deprecated.
-    Configure the title to display like any other field, or set 'enable_base_field_custom_preprocess_skipping'
-    to silence this error if you do wish to hide the title and are using node templates other than those provided by core.")
-    $variables['label'] = $variables['elements']['title'];
-    unset($variables['elements']['title']);
-  }
+  if ($node->getEntityType()->get('enable_base_field_custom_preprocess_skipping') {
+    trigger_error("The enable_base_field_custom_preprocess_skipping node flag is deprecated. No replacement is needed, code that sets it can be removed.", E_USER_DEPRECATED )
+  };
 
   $variables['url'] = !$node->isNew() ? $node->toUrl('canonical')->toString() : NULL;
 

core/modules/node/templates/node.html.twig

@@ -70,25 +70,6 @@
 #}
 <article{{ attributes }}>
 
-  {{ title_prefix }}
-  {% if label and not page %}
-  {% deprecated 'Core node templates will no longer render titles automatically, configure the display of the title like other fields.' %}
-    <h2{{ title_attributes }}>
-      <a href="{{ url }}" rel="bookmark">{{ label }}</a>
-    </h2>
-  {% endif %}
-  {{ title_suffix }}
-
-  {% if display_submitted %}
-    <footer>
-      {{ author_picture }}
-      <div{{ author_attributes }}>
-        {% trans %}Submitted by {{ author_name }} on {{ date }}{% endtrans %}
-        {{ metadata }}
-      </div>
-    </footer>
-  {% endif %}
-
   <div{{ content_attributes }}>
     {{ content }}
   </div>