Issue #3085608 by Wim Leers, mikelutz, voleger, larowlan: [Symfony 4] Symfony...

Issue #3085608 by Wim Leers, mikelutz, voleger, larowlan: [Symfony 4] Symfony console command ::execute() methods should return 0 on success

composer/Plugin/Scaffold/ComposerScaffoldCommand.php

@@ -47,6 +47,7 @@ protected function configure() {
   protected function execute(InputInterface $input, OutputInterface $output) {
     $handler = new Handler($this->getComposer(), $this->getIO());
     $handler->scaffold();
+    return 0;
   }
 
 }

core/lib/Drupal/Core/Command/DbDumpCommand.php

@@ -60,6 +60,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $schema_tables = explode(',', $schema_tables);
 
     $output->writeln($this->generateScript($connection, $schema_tables), OutputInterface::OUTPUT_RAW);
+    return 0;
   }
 
   /**

core/lib/Drupal/Core/Command/DbImportCommand.php

@@ -42,6 +42,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     $connection = $this->getDatabaseConnection($input);
     $this->runScript($connection, $script);
     $output->writeln('Import completed successfully.');
+    return 0;
   }
 
   /**

core/lib/Drupal/Core/Command/GenerateProxyClassCommand.php

@@ -83,6 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       $output->writeln(sprintf('Proxy of class %s written to %s', $class_name, $proxy_filename));
     }
 
+    return 0;
   }
 
 }

core/modules/system/tests/src/Kernel/Scripts/DbCommandBaseTest.php

@@ -129,6 +129,7 @@ public function getDatabaseConnection(InputInterface $input) {
    */
   protected function execute(InputInterface $input, OutputInterface $output) {
     // Empty implementation for testing.
+    return 0;
   }
 
 }

core/tests/Drupal/TestSite/Commands/TestSiteInstallCommand.php

@@ -114,6 +114,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
         ['Site path', $this->siteDirectory],
       ]);
     }
+
+    return 0;
   }
 
   /**

core/tests/Drupal/TestSite/Commands/TestSiteReleaseLocksCommand.php

@@ -32,6 +32,7 @@ protected function configure() {
   protected function execute(InputInterface $input, OutputInterface $output) {
     TestDatabase::releaseAllTestLocks();
     $output->writeln('<info>Successfully released all the test database locks</info>');
+    return 0;
   }
 
 }

core/tests/Drupal/TestSite/Commands/TestSiteTearDownCommand.php

@@ -63,6 +63,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
     }
 
     $output->writeln("<info>Successfully uninstalled $db_prefix test site</info>");
+
+    return 0;
   }
 
   /**

core/tests/Drupal/TestSite/Commands/TestSiteUserLoginCommand.php

@@ -66,6 +66,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
       ->load($uid);
     $url = user_pass_reset_url($userEntity) . '/login';
     $output->writeln($url);
+
+    return 0;
   }
 
 }