Issue #3153455 by Berdir, larowlan, Eduardo Morales Alberti, Gauravmahlawat,...

Issue #3153455 by Berdir, larowlan, Eduardo Morales Alberti, Gauravmahlawat, sleepingmonk, PhilippJC, alexpott, catch, daffie, jibran: UID base field override configs can still have old default value callbacks

core/modules/media/media.post_update.php

@@ -5,6 +5,8 @@
  * Post update functions for Media.
  */
 
+use Drupal\Core\Field\Entity\BaseFieldOverride;
+
 /**
  * Implements hook_removed_post_updates().
  */
@@ -16,3 +18,19 @@ function media_removed_post_updates() {
     'media_post_update_add_status_extra_filter' => '9.0.0',
   ];
 }
+
+/**
+ * Updates stale references to Drupal\media\Entity\Media::getCurrentUserId.
+ */
+function media_post_update_modify_base_field_author_override() {
+  $uid_fields = \Drupal::entityTypeManager()
+    ->getStorage('base_field_override')
+    ->getQuery()
+    ->condition('entity_type', 'media')
+    ->condition('field_name', 'uid')
+    ->condition('default_value_callback', 'Drupal\media\Entity\Media::getCurrentUserId')
+    ->execute();
+  foreach (BaseFieldOverride::loadMultiple($uid_fields) as $base_field_override) {
+    $base_field_override->setDefaultValueCallback('Drupal\media\Entity\Media::getDefaultEntityOwner')->save();
+  }
+}

core/modules/node/node.post_update.php

@@ -5,6 +5,7 @@
  * Post update functions for Node.
  */
 
+use Drupal\Core\Field\Entity\BaseFieldOverride;
 use Drupal\views\Entity\View;
 
 /**
@@ -54,3 +55,19 @@ function node_post_update_glossary_view_published() {
 function node_post_update_rebuild_node_revision_routes() {
   // Empty update to rebuild routes.
 }
+
+/**
+ * Updates stale references to Drupal\node\Entity\Node::getCurrentUserId.
+ */
+function node_post_update_modify_base_field_author_override() {
+  $uid_fields = \Drupal::entityTypeManager()
+    ->getStorage('base_field_override')
+    ->getQuery()
+    ->condition('entity_type', 'node')
+    ->condition('field_name', 'uid')
+    ->condition('default_value_callback', 'Drupal\node\Entity\Node::getCurrentUserId')
+    ->execute();
+  foreach (BaseFieldOverride::loadMultiple($uid_fields) as $base_field_override) {
+    $base_field_override->setDefaultValueCallback('Drupal\node\Entity\Node::getDefaultEntityOwner')->save();
+  }
+}

core/modules/node/tests/src/Functional/Update/NodeContentTranslationUpdateTest.php

+<?php
+
+namespace Drupal\Tests\node\Functional\Update;
+
+use Drupal\FunctionalTests\Update\UpdatePathTestBase;
+
+/**
+ * Tests updating to Drupal 9 with content-translation for author fields.
+ *
+ * @group node
+ * @group legacy
+ */
+class NodeContentTranslationUpdateTest extends UpdatePathTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setDatabaseDumpFiles() {
+    $this->databaseDumpFiles = [
+      dirname(__DIR__, 3) . '/fixtures/update/drupal8-9-1-bare.minimal-content-translation.php.gz',
+    ];
+  }
+
+  /**
+   * Tests that content-translation base field overrides are updated.
+   *
+   * @see node_post_update_modify_base_field_author_override
+   */
+  public function testContentTranslationDefaultValueBaseFieldOverrideUpdates() {
+    $config = \Drupal::config('core.base_field_override.node.article.uid');
+
+    $this->assertEquals('Drupal\node\Entity\Node::getCurrentUserId', $config->get('default_value_callback'));
+
+    $this->runUpdates();
+
+    $entity_field_manager = \Drupal::service('entity_field.manager');
+    $fields = $entity_field_manager->getFieldDefinitions('node', 'article');
+    $author = $fields['uid'];
+    $this->assertEquals('Drupal\node\Entity\Node::getDefaultEntityOwner', $author->getDefaultValueCallback());
+  }
+
+}

core/modules/workspaces/workspaces.post_update.php

@@ -5,6 +5,8 @@
  * Post update functions for the Workspaces module.
  */
 
+use Drupal\Core\Field\Entity\BaseFieldOverride;
+
 /**
  * Removes the workspace association entity and field schema data.
  */
@@ -35,3 +37,19 @@ function workspaces_removed_post_updates() {
     'workspaces_post_update_update_deploy_form_display' => '9.0.0',
   ];
 }
+
+/**
+ * Updates stale references to Drupal\workspaces\Entity\Workspace::getCurrentUserId.
+ */
+function workspaces_post_update_modify_base_field_author_override() {
+  $uid_fields = \Drupal::entityTypeManager()
+    ->getStorage('base_field_override')
+    ->getQuery()
+    ->condition('entity_type', 'workspace')
+    ->condition('field_name', 'uid')
+    ->condition('default_value_callback', 'Drupal\workspaces\Entity\Workspace::getCurrentUserId')
+    ->execute();
+  foreach (BaseFieldOverride::loadMultiple($uid_fields) as $base_field_override) {
+    $base_field_override->setDefaultValueCallback('Drupal\workspaces\Entity\Workspace::getDefaultEntityOwner')->save();
+  }
+}