Issue #2336569 by bnjmnm, lauriii, Stefan Lehmann, samaphp, HeikeT,...

Issue #2336569 by bnjmnm, lauriii, Stefan Lehmann, samaphp, HeikeT, tompagabor, katherined, larowlan, alexpott, pghaemim, raedkhurayji: Remove incomplete <span> usage from #field_prefix and #field_suffix

core/lib/Drupal/Core/Render/Element/FormElement.php

@@ -46,10 +46,16 @@
  *   are called to validate the input. Arguments: $element, $form_state, $form.
  * - #field_prefix: (string) Prefix to display before the HTML input element.
  *   Should be translated, normally. If it is not already wrapped in a safe
- *   markup object, will be filtered for XSS safety.
+ *   markup object, will be filtered for XSS safety. Note that the contents of
+ *   this prefix are wrapped in a <span> element, so the value should not
+ *   contain block level HTML. Any HTML added must be valid, i.e. any tags
+ *   introduced inside this prefix must also be terminated within the prefix.
  * - #field_suffix: (string) Suffix to display after the HTML input element.
  *   Should be translated, normally. If it is not already wrapped in a safe
- *   markup object, will be filtered for XSS safety.
+ *   markup object, will be filtered for XSS safety. Note that the contents of
+ *   this suffix are wrapped in a <span> element, so the value should not
+ *   contain block level HTML. Any HTML must also be valid, i.e. any tags
+ *   introduce inside this suffix must also be terminated within the suffix.
  * - #input: (bool, internal) Whether or not the element accepts input.
  * - #parents: (string[], read-only) Array of names of the element's parents
  *   for purposes of getting values out of $form_state. See also

core/modules/field/tests/src/FunctionalJavascript/EntityReference/EntityReferenceAdminTest.php

@@ -88,7 +88,7 @@ public function testFieldAdminHandler() {
 
     $page->findField('new_storage_type')->setValue('entity_reference');
     $assert_session->waitForField('label')->setValue('Test');
-    $machine_name = $assert_session->waitForElement('xpath', '//*[@id="edit-label-machine-name-suffix"]/span[2]/span[contains(text(), "field_test")]');
+    $machine_name = $assert_session->waitForElement('xpath', '//*[@id="edit-label-machine-name-suffix"]/span[contains(text(), "field_test")]');
     $this->assertNotEmpty($machine_name);
     $page->pressButton('Save and continue');
 

core/modules/field_ui/src/Form/FieldStorageAddForm.php

@@ -187,9 +187,7 @@ public function buildForm(array $form, FormStateInterface $form_state, $entity_t
     $field_prefix = $this->config('field_ui.settings')->get('field_prefix');
     $form['new_storage_wrapper']['field_name'] = [
       '#type' => 'machine_name',
-      // This field should stay LTR even for RTL languages.
-      '#field_prefix' => '<span dir="ltr">' . $field_prefix,
-      '#field_suffix' => '</span>&lrm;',
+      '#field_prefix' => $field_prefix,
       '#size' => 15,
       '#description' => $this->t('A unique machine-readable name containing letters, numbers, and underscores.'),
       // Calculate characters depending on the length of the field prefix

core/modules/views/src/Plugin/views/display/PathPluginBase.php

@@ -439,8 +439,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
           '#title' => $this->t('Path'),
           '#description' => $this->t('This view will be displayed by visiting this path on your site. You may use "%" in your URL to represent values that will be used for contextual filters: For example, "node/%/feed". If needed you can even specify named route parameters like taxonomy/term/%taxonomy_term'),
           '#default_value' => $this->getOption('path'),
-          '#field_prefix' => '<span dir="ltr">' . Url::fromRoute('<none>', [], ['absolute' => TRUE])->toString(),
-          '#field_suffix' => '</span>&lrm;',
+          '#field_prefix' => '<span dir="ltr">' . Url::fromRoute('<none>', [], ['absolute' => TRUE])->toString() . '</span>&lrm;',
           '#attributes' => ['dir' => LanguageInterface::DIRECTION_LTR],
           // Account for the leading backslash.
           '#maxlength' => 254,