Issue #2105583 by neclimdul, tim.plunkett, dawehner, Mile23: Add some sane...

Issue #2105583 by neclimdul, tim.plunkett, dawehner, Mile23: Add some sane strictness to phpunit tests to catch risky tests

core/modules/simpletest/tests/fixtures/simpletest_phpunit_run_command_test.php

@@ -17,6 +17,7 @@ public function testWillDie() {
     if (getenv('SimpletestPhpunitRunCommandTestWillDie') === 'fail') {
       exit(2);
     }
+    $this->assertTrue(TRUE, 'Assertion to ensure test pass');
   }
 }
 

core/phpunit.xml.dist

 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit bootstrap="tests/bootstrap.php" colors="true">
+<!-- TODO set checkForUnintentionallyCoveredCode="true" once https://www.drupal.org/node/2626832 is resolved. -->
+<phpunit bootstrap="tests/bootstrap.php" colors="true"
+         beStrictAboutTestsThatDoNotTestAnything="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutChangesToGlobalState="true"
+         checkForUnintentionallyCoveredCode="false">
   <php>
     <!-- Set error reporting to E_ALL. -->
     <ini name="error_reporting" value="32767"/>