Skip to content
Snippets Groups Projects
Commit 29bc7312 authored by Stefan Ruijsenaars's avatar Stefan Ruijsenaars
Browse files

Issue #1880224 by joelpittet, thedavidmeister, rooby, validoll, monta: Notice:...

Issue #1880224 by joelpittet, thedavidmeister, rooby, validoll, monta: Notice: Undefined index: value in theme_status_report() (line 2577 of modules/system/system.admin.inc)
parent 29473bdf
No related branches found
No related tags found
No related merge requests found
......@@ -31,6 +31,19 @@ function update_script_test_requirements($phase) {
'severity' => REQUIREMENT_ERROR,
);
break;
case REQUIREMENT_INFO:
$requirements['update_script_test_stop'] = array(
'title' => 'Update script test stop',
'value' => 'Error',
'description' => 'This is a requirements error provided by the update_script_test module to stop the page redirect for the info.',
'severity' => REQUIREMENT_ERROR,
);
$requirements['update_script_test'] = array(
'title' => 'Update script test',
'description' => 'This is a requirements info provided by the update_script_test module.',
'severity' => REQUIREMENT_INFO,
);
break;
}
}
......
......@@ -2597,6 +2597,8 @@ function theme_status_report($variables) {
if (empty($requirement['#type'])) {
$severity = $severities[isset($requirement['severity']) ? (int) $requirement['severity'] : REQUIREMENT_OK];
$severity['icon'] = '<div title="' . $severity['title'] . '"><span class="element-invisible">' . $severity['title'] . '</span></div>';
// The requirement's 'value' key is optional, provide a default value.
$requirement['value'] = isset($requirement['value']) ? $requirement['value'] : '';
// Output table row(s)
if (!empty($requirement['description'])) {
......
......@@ -2449,6 +2449,12 @@ class UpdateScriptFunctionalTest extends DrupalWebTestCase {
$this->assertText('This is a requirements error provided by the update_script_test module.');
$this->clickLink('try again');
$this->assertText('This is a requirements error provided by the update_script_test module.');
// Check if the optional 'value' key displays without a notice.
variable_set('update_script_test_requirement_type', REQUIREMENT_INFO);
$this->drupalGet($this->update_url, array('external' => TRUE));
$this->assertText('This is a requirements info provided by the update_script_test module.');
$this->assertNoText('Notice: Undefined index: value in theme_status_report()');
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment