Issue #2035725 by webflo, sivaji, Xano: Remove visibility__active_tab from block.schema.yml.

core/modules/block/config/schema/block.schema.yml

@@ -59,9 +59,6 @@ block.block.*:
               sequence:
                - type: string
                  label: 'Node type'
-        visibility__active_tab:
-          type: string
-          label: 'Visibility active tab'
     plugin:
       type: string
       label: 'Plugin'

core/modules/block/lib/Drupal/block/BlockFormController.php

@@ -319,6 +319,7 @@ public function submit(array $form, array &$form_state) {
       'values' => &$form_state['values']['settings'],
       'errors' => $form_state['errors'],
     );
+
     // Call the plugin submit handler.
     $entity->getPlugin()->submitConfigurationForm($form, $settings);
 
@@ -340,6 +341,21 @@ public function submit(array $form, array &$form_state) {
     );
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function buildEntity(array $form, array &$form_state) {
+    $entity = parent::buildEntity($form, $form_state);
+
+    // visibility__active_tab is Form API state and not configuration.
+    // @todo Fix vertical tabs.
+    $visibility = $entity->get('visibility');
+    unset($visibility['visibility__active_tab']);
+    $entity->set('visibility', $visibility);
+
+    return $entity;
+  }
+
   /**
    * Generates a unique machine name for a block.
    *

core/modules/block/tests/modules/block_test/config/block.block.test_block.yml

@@ -18,4 +18,3 @@ visibility:
     roles: {  }
   node_type:
     types: {  }
-  visibility__active_tab: edit-visibility-path

core/profiles/minimal/config/block.block.stark_admin.yml

@@ -18,4 +18,3 @@ visibility:
     roles: {  }
   node_type:
     types: {  }
-  visibility__active_tab: edit-visibility-path

core/profiles/minimal/config/block.block.stark_login.yml

@@ -18,4 +18,3 @@ visibility:
     roles: {  }
   node_type:
     types: {  }
-  visibility__active_tab: edit-visibility-path

core/profiles/minimal/config/block.block.stark_tools.yml

@@ -18,4 +18,3 @@ visibility:
     roles: {  }
   node_type:
     types: {  }
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_breadcrumbs.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_content.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_footer.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_help.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_login.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_powered.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_search.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.bartik_tools.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.seven_breadcrumbs.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.seven_content.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.seven_help.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path

core/profiles/standard/config/block.block.seven_login.yml

@@ -21,4 +21,3 @@ visibility:
     types:
       article: '0'
       page: '0'
-  visibility__active_tab: edit-visibility-path