Issue #2708255 by dawehner, yoroy, swentel, Jacine, Gábor Hojtsy: Add support...

Issue #2708255 by dawehner, yoroy, swentel, Jacine, Gábor Hojtsy: Add support for #required on #type => details

core/includes/form.inc

@@ -254,6 +254,7 @@ function template_preprocess_details(&$variables) {
   $variables['description'] = (!empty($element['#description'])) ? $element['#description'] : '';
   $variables['children'] = (isset($element['#children'])) ? $element['#children'] : '';
   $variables['value'] = (isset($element['#value'])) ? $element['#value'] : '';
+  $variables['required'] = !empty($element['#required']) ? $element['#required'] : NULL;
 
   // Suppress error messages.
   $variables['errors'] = NULL;

core/modules/system/src/Tests/Form/ElementTest.php

@@ -137,6 +137,20 @@ function testGroupElements() {
     $this->assertTrue(count($elements) == 1);
   }
 
+  /**
+   * Tests the #required property on details and fieldset elements.
+   */
+  public function testRequiredFieldsetsAndDetails() {
+    $this->drupalGet('form-test/group-details');
+    $this->assertFalse($this->cssSelect('summary.form-required'));
+    $this->drupalGet('form-test/group-details/1');
+    $this->assertTrue($this->cssSelect('summary.form-required'));
+    $this->drupalGet('form-test/group-fieldset');
+    $this->assertFalse($this->cssSelect('span.form-required'));
+    $this->drupalGet('form-test/group-fieldset/1');
+    $this->assertTrue($this->cssSelect('span.form-required'));
+  }
+
   /**
    * Tests a form with a autocomplete setting..
    */

core/modules/system/templates/details.html.twig

@@ -17,8 +17,14 @@
  */
 #}
 <details{{ attributes }}>
+  {%
+    set summary_classes = [
+      required ? 'js-form-required',
+      required ? 'form-required',
+    ]
+  %}
   {%- if title -%}
-    <summary{{ summary_attributes }}>{{ title }}</summary>
+    <summary{{ summary_attributes.addClass(summary_classes) }}>{{ title }}</summary>
   {%- endif -%}
 
   {% if errors %}

core/modules/system/tests/modules/form_test/form_test.routing.yml

@@ -418,10 +418,11 @@ form_test.description_display:
     _access: 'TRUE'
 
 form_test.group_details:
-  path: '/form-test/group-details'
+  path: '/form-test/group-details/{required}'
   defaults:
     _form: '\Drupal\form_test\Form\FormTestGroupDetailsForm'
     _title: 'Group details testing'
+    required: FALSE
   requirements:
     _access: 'TRUE'
 
@@ -434,10 +435,11 @@ form_test.group_container:
     _access: 'TRUE'
 
 form_test.group_fieldset:
-  path: '/form-test/group-fieldset'
+  path: '/form-test/group-fieldset/{required}'
   defaults:
     _form: '\Drupal\form_test\Form\FormTestGroupFieldsetForm'
     _title: 'Group fieldset testing'
+    required: FALSE
   requirements:
     _access: 'TRUE'
 

core/modules/system/tests/modules/form_test/src/Form/FormTestGroupDetailsForm.php

@@ -20,11 +20,12 @@ public function getFormId() {
   /**
    * {@inheritdoc}
    */
-  public function buildForm(array $form, FormStateInterface $form_state) {
+  public function buildForm(array $form, FormStateInterface $form_state, $required = FALSE) {
     $form['details'] = array(
       '#type' => 'details',
       '#title' => 'Root element',
       '#open' => TRUE,
+      '#required' => !empty($required),
     );
     $form['meta'] = array(
       '#type' => 'details',

core/modules/system/tests/modules/form_test/src/Form/FormTestGroupFieldsetForm.php

@@ -20,10 +20,11 @@ public function getFormId() {
   /**
    * {@inheritdoc}
    */
-  public function buildForm(array $form, FormStateInterface $form_state) {
+  public function buildForm(array $form, FormStateInterface $form_state, $required = FALSE) {
     $form['fieldset'] = array(
       '#type' => 'fieldset',
       '#title' => 'Fieldset',
+      '#required' => !empty($required),
     );
     $form['meta'] = array(
       '#type' => 'container',

core/themes/classy/templates/form/details.html.twig

@@ -16,7 +16,13 @@
 #}
 <details{{ attributes }}>
   {%- if title -%}
-    <summary{{ summary_attributes }}>{{ title }}</summary>
+    {%
+      set summary_classes = [
+        required ? 'js-form-required',
+        required ? 'form-required',
+      ]
+    %}
+    <summary{{ summary_attributes.addClass(summary_classes) }}>{{ title }}</summary>
   {%- endif -%}
   <div class="details-wrapper">
     {% if errors %}

core/themes/stable/templates/form/details.html.twig

@@ -15,8 +15,14 @@
  */
 #}
 <details{{ attributes }}>
+  {%
+    set summary_classes = [
+      required ? 'js-form-required',
+      required ? 'form-required',
+    ]
+  %}
   {%- if title -%}
-    <summary{{ summary_attributes }}>{{ title }}</summary>
+    <summary{{ summary_attributes.addClass(summary_classes) }}>{{ title }}</summary>
   {%- endif -%}
 
   {% if errors %}