Skip to content
Snippets Groups Projects
Commit 082f8910 authored by catch's avatar catch
Browse files

Issue #3443494 by smustgrave: Remove deprecated code from lib/Test and lib/TypedData

parent d94c50de
Branches
Tags
26 merge requests!11131[10.4.x-only-DO-NOT-MERGE]: Issue ##2842525 Ajax attached to Views exposed filter form does not trigger callbacks,!9470[10.3.x-only-DO-NOT-MERGE]: #3331771 Fix file_get_contents(): Passing null to parameter,!8540Issue #3457061: Bootstrap Modal dialog Not closing after 10.3.0 Update,!8528Issue #3456871 by Tim Bozeman: Support NULL services,!8373Issue #3427374 by danflanagan8, Vighneshh: taxonomy_tid ViewsArgumentDefault...,!3878Removed unused condition head title for views,!3818Issue #2140179: $entity->original gets stale between updates,!3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists,!3731Claro: role=button on status report items,!3651Issue #3347736: Create new SDC component for Olivero (header-search),!3531Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!3355Issue #3209129: Scrolling problems when adding a block via layout builder,!3154Fixes #2987987 - CSRF token validation broken on routes with optional parameters.,!3133core/modules/system/css/components/hidden.module.css,!2964Issue #2865710 : Dependencies from only one instance of a widget are used in display modes,!2812Issue #3312049: [Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns for NULL,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2062Issue #3246454: Add weekly granularity to views date sort,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!877Issue #2708101: Default value for link text is not saved,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493
Pipeline #159904 canceled
Pipeline: drupal

#159905

    ......@@ -114,22 +114,6 @@ trait TestSetupTrait {
    */
    protected $testId;
    /**
    * Returns the database connection to the site under test.
    *
    * @return \Drupal\Core\Database\Connection
    * The database connection to use for inserting assertions.
    *
    * @deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no
    * replacement.
    *
    * @see https://www.drupal.org/node/3176816
    */
    public static function getDatabaseConnection() {
    @trigger_error(__METHOD__ . ' is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/node/3176816', E_USER_DEPRECATED);
    return SimpletestTestRunResultsStorage::getConnection();
    }
    /**
    * Generates a database prefix for running tests.
    *
    ......
    <?php
    namespace Drupal\Core\TypedData\Validation;
    // phpcs:ignoreFile Portions of this file are a direct copy of
    // \Symfony\Component\Validator\Violation\ConstraintViolationBuilder.
    use Drupal\Core\Validation\ConstraintViolationBuilder as NewConstraintViolationBuilder;
    use Drupal\Core\Validation\TranslatorInterface;
    use Symfony\Component\Validator\Constraint;
    use Symfony\Component\Validator\ConstraintViolationList;
    /**
    * Defines a constraint violation builder for the Typed Data validator.
    *
    * We do not use the builder provided by Symfony as it is marked internal.
    *
    */
    class ConstraintViolationBuilder extends NewConstraintViolationBuilder {
    /**
    * Constructs a new ConstraintViolationBuilder instance.
    *
    * @param \Symfony\Component\Validator\ConstraintViolationList $violations
    * The violation list.
    * @param \Symfony\Component\Validator\Constraint $constraint
    * The constraint.
    * @param string $message
    * The message.
    * @param array $parameters
    * The message parameters.
    * @param mixed $root
    * The root.
    * @param string $propertyPath
    * The property string.
    * @param mixed $invalidValue
    * The invalid value.
    * @param \Drupal\Core\Validation\TranslatorInterface $translator
    * The translator.
    * @param null $translationDomain
    * (optional) The translation domain.
    */
    public function __construct(ConstraintViolationList $violations, Constraint $constraint, $message, array $parameters, $root, $propertyPath, $invalidValue, TranslatorInterface $translator, $translationDomain = null) {
    @trigger_error(__CLASS__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Core\Validation\ConstraintViolationBuilder. See https://www.drupal.org/node/3396238', E_USER_DEPRECATED);
    parent::__construct($violations, $constraint, $message, $parameters, $root, $propertyPath, $invalidValue, $translator, $translationDomain);
    }
    }
    <?php
    namespace Drupal\Core\TypedData\Validation;
    use Drupal\Core\Validation\ExecutionContext as NewExecutionContext;
    use Drupal\Core\Validation\TranslatorInterface;
    use Symfony\Component\Validator\Validator\ValidatorInterface;
    /**
    * Defines an execution context class.
    *
    * We do not use the context provided by Symfony as it is marked internal, so
    * this class is pretty much the same, but has some code style changes as well
    * as exceptions for methods we don't support.
    */
    class ExecutionContext extends NewExecutionContext {
    /**
    * Creates a new ExecutionContext.
    *
    * @param \Symfony\Component\Validator\Validator\ValidatorInterface $validator
    * The validator.
    * @param mixed $root
    * The root.
    * @param \Drupal\Core\Validation\TranslatorInterface $translator
    * The translator.
    * @param string $translationDomain
    * (optional) The translation domain.
    *
    * @internal Called by \Drupal\Core\Validation\ExecutionContextFactory.
    * Should not be used in user code.
    */
    public function __construct(ValidatorInterface $validator, $root, TranslatorInterface $translator, $translationDomain = NULL) {
    @trigger_error(__CLASS__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Core\Validation\ExecutionContext. See https://www.drupal.org/node/3396238', E_USER_DEPRECATED);
    parent::__construct($validator, $root, $translator, $translationDomain);
    }
    }
    <?php
    namespace Drupal\Core\TypedData\Validation;
    use Drupal\Core\Validation\ExecutionContextFactory as NewExecutionContextFactory;
    use Drupal\Core\Validation\TranslatorInterface;
    /**
    * Defines an execution factory for the Typed Data validator.
    *
    * We do not use the factory provided by Symfony as it is marked internal.
    */
    class ExecutionContextFactory extends NewExecutionContextFactory {
    /**
    * Constructs a new ExecutionContextFactory instance.
    *
    * @param \Drupal\Core\Validation\TranslatorInterface $translator
    * The translator instance.
    * @param string $translationDomain
    * (optional) The translation domain.
    */
    public function __construct(TranslatorInterface $translator, $translationDomain = NULL) {
    @trigger_error(__CLASS__ . ' is deprecated in drupal:10.3.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Core\Validation\ExecutionContextFactory. See https://www.drupal.org/node/3396238', E_USER_DEPRECATED);
    parent::__construct($translator, $translationDomain);
    }
    }
    ......@@ -180,7 +180,7 @@ public function testStatusPage() {
    $this->assertSession()->elementNotExists('xpath', "//a[contains(@href, 'http://example.com/deprecated_theme')]");
    // Check if pg_trgm extension is enabled on postgres.
    if ($this->getDatabaseConnection()->databaseType() == 'pgsql') {
    if (\Drupal::database()->databaseType() == 'pgsql') {
    $this->assertSession()->pageTextContains('PostgreSQL pg_trgm extension');
    $elements = $this->xpath('//details[@class="system-status-report__entry"]//div[contains(text(), :text)]', [
    ':text' => 'The pg_trgm PostgreSQL extension is present.',
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment