Issue #3465507 by mstrelan, nicxvan: Deprecate and / or remove unused...

Issue #3465507 by mstrelan, nicxvan: Deprecate and / or remove unused Controllers and routes from WebAssert tests

core/modules/system/tests/modules/test_page_test/src/Controller/Test.php

@@ -5,7 +5,6 @@
 use Drupal\Core\Render\Markup;
 use Drupal\Core\Url;
 use Symfony\Component\HttpFoundation\RedirectResponse;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
 /**
@@ -96,42 +95,6 @@ public function error() {
     ];
   }
 
-  /**
-   * Sets an HTTP header.
-   *
-   * @param string $name
-   *   The header name.
-   * @param string $value
-   *   (optional) The header value ot set.
-   */
-  public function setHeader($name, $value = NULL) {
-    $response = new Response();
-    $response->headers->set($name, $value);
-    return $response;
-  }
-
-  /**
-   * Renders a page with encoded markup.
-   *
-   * @return array
-   *   A render array as expected by
-   *   \Drupal\Core\Render\RendererInterface::render().
-   */
-  public function renderEncodedMarkup() {
-    return ['#plain_text' => 'Bad html <script>alert(123);</script>'];
-  }
-
-  /**
-   * Renders a page with pipe character in link test.
-   *
-   * @return array
-   *   A render array as expected by
-   *   \Drupal\Core\Render\RendererInterface::render().
-   */
-  public function renderPipeInLink() {
-    return ['#markup' => '<a href="http://example.com">foo|bar|baz</a>'];
-  }
-
   public function escapedCharacters() {
     return [
       '#prefix' => '<div class="escaped">',
@@ -170,56 +133,6 @@ public function metaRefresh() {
     return new RedirectResponse(Url::fromRoute('test_page_test.test_page', [], ['absolute' => TRUE])->toString(), 302);
   }
 
-  /**
-   * Returns a page render array with 2 elements with the same HTML IDs.
-   *
-   * @return array
-   *   A render array as expected by
-   *   \Drupal\Core\Render\RendererInterface::render().
-   */
-  public function renderPageWithDuplicateIds() {
-    return [
-      '#type' => 'container',
-      'title' => [
-        '#type' => 'html_tag',
-        '#tag' => 'h1',
-        '#value' => 'Hello',
-        '#attributes' => ['id' => 'page-element'],
-      ],
-      'description' => [
-        '#type' => 'html_tag',
-        '#tag' => 'h2',
-        '#value' => 'World',
-        '#attributes' => ['id' => 'page-element'],
-      ],
-    ];
-  }
-
-  /**
-   * Returns a page render array with 2 elements with the unique HTML IDs.
-   *
-   * @return array
-   *   A render array as expected by
-   *   \Drupal\Core\Render\RendererInterface::render().
-   */
-  public function renderPageWithoutDuplicateIds() {
-    return [
-      '#type' => 'container',
-      'title' => [
-        '#type' => 'html_tag',
-        '#tag' => 'h1',
-        '#value' => 'Hello',
-        '#attributes' => ['id' => 'page-element-title'],
-      ],
-      'description' => [
-        '#type' => 'html_tag',
-        '#tag' => 'h2',
-        '#value' => 'World',
-        '#attributes' => ['id' => 'page-element-description'],
-      ],
-    ];
-  }
-
   /**
    * Returns a page while triggering deprecation notices.
    */

core/modules/system/tests/modules/test_page_test/test_page_test.routing.yml

@@ -36,13 +36,6 @@ test_page_test.dynamic_title:
   requirements:
     _access: 'TRUE'
 
-test_page_test.admin_render_title:
-  path: '/admin/test-render-title'
-  defaults:
-    _controller: '\Drupal\test_page_test\Controller\Test::renderTitle'
-  requirements:
-    _access: 'TRUE'
-
 test_page_test.http_response_exception:
   path: '/test-http-response-exception/{code}'
   defaults:
@@ -59,30 +52,6 @@ test_page_test.error:
   requirements:
     _access: 'TRUE'
 
-test_page_test.null_header:
-  path: '/test-null-header'
-  defaults:
-    _controller: '\Drupal\test_page_test\Controller\Test::setHeader'
-    name: Null-Header
-  requirements:
-    _access: 'TRUE'
-
-test_page_test.encoded:
-  path: '/test-encoded'
-  defaults:
-    _title: 'Page with encoded HTML'
-    _controller: '\Drupal\test_page_test\Controller\Test::renderEncodedMarkup'
-  requirements:
-    _access: 'TRUE'
-
-test_page_test.pipe:
-  path: '/test-pipe-char'
-  defaults:
-    _title: 'Page with pipe char in link'
-    _controller: '\Drupal\test_page_test\Controller\Test::renderPipeInLink'
-  requirements:
-    _access: 'TRUE'
-
 test_page_test.field_xpath:
   path: '/test-field-xpath'
   defaults:
@@ -123,20 +92,6 @@ test_page_test.meta_refresh:
   requirements:
     _access: 'TRUE'
 
-test_page_test.page_with_duplicate_ids:
-  path: '/test-page-with-duplicate-ids'
-  defaults:
-    _controller: '\Drupal\test_page_test\Controller\Test::renderPageWithDuplicateIds'
-  requirements:
-    _access: 'TRUE'
-
-test_page_test.page_without_duplicate_ids:
-  path: '/test-page-without-duplicate-ids'
-  defaults:
-    _controller: '\Drupal\test_page_test\Controller\Test::renderPageWithoutDuplicateIds'
-  requirements:
-    _access: 'TRUE'
-
 test_page_test.deprecations:
   path: '/test-deprecations'
   defaults: