Skip to content
Snippets Groups Projects
Unverified Commit 38c6162c authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3224861 by Spokje: PHPCS failure in /core/modules/tour/src/TourViewBuilder.php

parent fd0b13a8
Branches
Tags
17 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!1896Issue #2940605: Can only intentionally re-render an entity with references 20 times,!1101Issue #2412669 by claudiu.cristea, Julfabre, sidharrell, catch, daffie,...,!1039Issue #2556069 by claudiu.cristea, bnjmnm, lauriii, pfrenssen, Tim Bozeman,...,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!1012Issue #3226887: Hreflang on non-canonical content pages,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!594Put each entity type table into a details element on admin/config/regional/content-language,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!512Issue #3207771: Menu UI node type form documentation points to non-existent function,!485Sets the autocomplete attribute for username/password input field on login form.,!449Issue #2784233: Allow multiple vocabularies in the taxonomy filter,!231Issue #2671162: summary text wysiwyg patch working fine on 9.2.0-dev,!43Resolve #3173180: Add UI for 'loading' html attribute to images,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -70,15 +70,15 @@ public function viewMultiple(array $entities = [], $view_mode = 'full', $langcod
// TourTipPluginInterface. This means the tour tip must be constructed
// with the deprecated getOutput() method. The resulting tour tip
// should be largely identical, with the following exceptions:
// 1 - If the tour tip `attributes` property included anything other
// than `data-class` or `data-id`, these additional attributes
// will not be available in the resulting tour tip. Note that such
// uses are uncommon.
// 2 - Although the tour tip content is identical, the markup
// structure will be different due to being rendered by Shepherd
// instead of Joyride. Themes extending Stable or Stable 9 will
// not experience these changes as a script is provided that
// reconstructs each tip to match Joyride's markup structure.
// - If the tour tip `attributes` property included anything other
// than `data-class` or `data-id`, these additional attributes
// will not be available in the resulting tour tip. Note that such
// uses are uncommon.
// - Although the tour tip content is identical, the markup structure
// will be different due to being rendered by Shepherd instead of
// Joyride. Themes extending Stable or Stable 9 will not experience
// these changes as a script is provided that reconstructs each tip
// to match Joyride's markup structure.
$attributes = (array) $tip->get('attributes');
if (array_diff(['data-class', 'data-id'], array_keys($attributes + ['data-class', 'data-id']))) {
trigger_error('The tour tips only support data-class and data-id attributes and they will have to be upgraded manually. See https://www.drupal.org/node/3204093', E_USER_WARNING);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment