Skip to content
Snippets Groups Projects
Commit 41769241 authored by catch's avatar catch
Browse files

Issue #3250299 by daffie, longwave: [Symfony6] A number of CKEditor5 tests fail for Symfony 5.4

parent 507fc5fe
No related branches found
No related tags found
31 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!1896Issue #2940605: Can only intentionally re-render an entity with references 20 times,!1459Issue #3087632: menu_name max length is too long,!1283Issue #2922435: "Add new comment" and "@count comments" links are not following accessibility good practices,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1213Issue #3236497: Allow other modules to opt out of security release message from update_page_top,!1185Issue 318778: Rerolled patch.,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!1018Issue #2793343: Dialog drupalAutoButtons option should be respected on initial load,!1014Issue #3226806: Move filter implementations from filter.module to plugin classes,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!939Issue #2971209: Allow the MediaLibraryUiBuilder service to use an alternative view display,!878Issue #3221534: throw an exception when IDs passed to loadMultiple() are badly formed,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!866Issue #2845319: The highlighting of the 'Home' menu-link does not respect query strings and fragment identifiers,!844Resolve #3036010 "Updaters",!8293023322 - Contextual Links Style Update,!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!449Issue #2784233: Allow multiple vocabularies in the taxonomy filter,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
Hide whitespace changes
Inline Side-by-side
core/modules/ckeditor5/src/Plugin/Validation/Constraint/EnabledConfigurablePluginsConstraintValidator.php
+ 1
− 1
View file @ 41769241
......@@ -51,7 +51,7 @@ public function validate($settings, Constraint $constraint) {
if (!isset($plugin_settings[$id]) || empty($plugin_settings[$id])) {
$this->context->buildViolation($constraint->message)
->setParameter('%plugin_label', $definition->label())
->setParameter('%plugin_label', (string) $definition->label())
->setParameter('%plugin_id', $id)
->atPath("plugins.$id")
->addViolation();
......
core/modules/ckeditor5/src/Plugin/Validation/Constraint/FundamentalCompatibilityConstraintValidator.php
+ 3
− 3
View file @ 41769241
......@@ -86,7 +86,7 @@ private function checkNoMarkupFilters(FilterFormatInterface $text_format, Fundam
);
foreach ($markup_filters as $markup_filter) {
$this->context->buildViolation($constraint->noMarkupFiltersMessage)
->setParameter('%filter_label', $markup_filter->getLabel())
->setParameter('%filter_label', (string) $markup_filter->getLabel())
->setParameter('%filter_plugin_id', $markup_filter->getPluginId())
->addViolation();
}
......@@ -111,7 +111,7 @@ private function checkHtmlRestrictionsAreCompatible(FilterFormatInterface $text_
if (!empty($forbidden_minimum_tags)) {
$offending_filter = static::findHtmlRestrictorFilterForbiddingTags($text_format, $minimum_tags);
$this->context->buildViolation($constraint->forbiddenElementsMessage)
->setParameter('%filter_label', $offending_filter->getLabel())
->setParameter('%filter_label', (string) $offending_filter->getLabel())
->setParameter('%filter_plugin_id', $offending_filter->getPluginId())
->addViolation();
}
......@@ -122,7 +122,7 @@ private function checkHtmlRestrictionsAreCompatible(FilterFormatInterface $text_
if (!empty($not_allowed_minimum_tags)) {
$offending_filter = static::findHtmlRestrictorFilterNotAllowingTags($text_format, $minimum_tags);
$this->context->buildViolation($constraint->nonAllowedElementsMessage)
->setParameter('%filter_label', $offending_filter->getLabel())
->setParameter('%filter_label', (string) $offending_filter->getLabel())
->setParameter('%filter_plugin_id', $offending_filter->getPluginId())
->addViolation();
}
......
core/modules/ckeditor5/src/Plugin/Validation/Constraint/ToolbarItemConditionsMetConstraintValidator.php
+ 4
− 4
View file @ 41769241
......@@ -61,7 +61,7 @@ public function validate($toolbar_item, Constraint $constraint) {
$image_upload_settings = $text_editor->getImageUploadSettings();
if (!isset($image_upload_settings['status']) || (bool) $image_upload_settings['status'] !== TRUE) {
$this->context->buildViolation($constraint->imageUploadStatusRequiredMessage)
->setParameter('%toolbar_item', $toolbar_item_label)
->setParameter('%toolbar_item', (string) $toolbar_item_label)
->setInvalidValue($toolbar_item)
->addViolation();
}
......@@ -74,8 +74,8 @@ public function validate($toolbar_item, Constraint $constraint) {
? $filters->get($required_value)->getLabel()
: $required_value;
$this->context->buildViolation($constraint->filterRequiredMessage)
->setParameter('%toolbar_item', $toolbar_item_label)
->setParameter('%filter', $filter_label)
->setParameter('%toolbar_item', (string) $toolbar_item_label)
->setParameter('%filter', (string) $filter_label)
->setInvalidValue($toolbar_item)
->addViolation();
}
......@@ -101,7 +101,7 @@ public function validate($toolbar_item, Constraint $constraint) {
$parameter = '%plugins';
}
$this->context->buildViolation($message)
->setParameter('%toolbar_item', $toolbar_item_label)
->setParameter('%toolbar_item', (string) $toolbar_item_label)
->setParameter($parameter, implode(', ', $missing_plugin_labels))
->setInvalidValue($toolbar_item)
->addViolation();
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment