Issue #3197754 by mohit_aghera, baliram.patil, ilgnerfagundes, Elin Yordanov,...

Issue #3197754 by mohit_aghera, baliram.patil, ilgnerfagundes, Elin Yordanov, larowlan, anmolgoyal74, guilhermevp: "Add new Forum topic" button appears also in forum containers

core/modules/forum/src/Controller/ForumController.php

@@ -235,8 +235,9 @@ protected function build($forums, TermInterface $term, $topics = [], $parents =
     }
     $this->renderer->addCacheableDependency($build, $term);
 
+    $is_forum = empty($term->forum_container->value);
     return [
-      'action' => $this->buildActionLinks($config->get('vocabulary'), $term),
+      'action' => ($is_forum) ? $this->buildActionLinks($config->get('vocabulary'), $term) : [],
       'forum' => $build,
       '#cache' => [
         'tags' => Cache::mergeTags($this->nodeEntityTypeDefinition->getListCacheTags(), $this->commentEntityTypeDefinition->getListCacheTags()),

core/modules/forum/tests/src/Functional/ForumTest.php

@@ -719,4 +719,21 @@ private function generateForumTopics() {
     }
   }
 
+  /**
+   * Evaluate whether "Add new Forum topic" button is present or not.
+   */
+  public function testForumTopicButton() {
+    $this->drupalLogin($this->adminUser);
+
+    // Validate that link doesn't exist on the forum container page.
+    $forum_container = $this->createForum('container');
+    $this->drupalGet('forum/' . $forum_container['tid']);
+    $this->assertSession()->linkNotExists('Add new Forum topic');
+
+    // Validate that link exists on forum page.
+    $forum = $this->createForum('forum');
+    $this->drupalGet('forum/' . $forum['tid']);
+    $this->assertSession()->linkExists('Add new Forum topic');
+  }
+
 }