Skip to content
Snippets Groups Projects
Verified Commit 74321e2f authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3502487 by lauriii, oily, ckrina: Make the menu link form less verbose

(cherry picked from commit 8357990c)
parent ec91b0d0
Branches
Tags
10 merge requests!11636Draft: Issue #3515643 by macsim: fieldNameExists method is inconsistent,!11515Issue #3480419 by mondrake, smustgrave, catch: Method...,!11380Issue #3490698 by catch, spokje: Bump MINIMUM_STABILITY back to 'stable' when...,!11281Use Drupal Core Leadership terminology in MAINTAINERS.txt,!11239Issue #3507548: Allow workspace changes listing to show all items, without a pager,!11238Fix issue #3051797,!11213Issue #3506743 by tomislav.matokovic: Increasing the color contrast for the navigation block title against the background of the navigation sidebar to at least 4.5:1,!11147Draft: Try to avoid manually setting required cache contexts,!11108Issue #3490298 by nicxvan: Profiles can be missed in OOP hooks,!11093Drupal on MongoDB 11.1.x
Pipeline #409050 passed
Pipeline: drupal

#409051

    ......@@ -293,7 +293,6 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
    $fields['title'] = BaseFieldDefinition::create('string')
    ->setLabel(t('Menu link title'))
    ->setDescription(t('The text to be used for this link in the menu.'))
    ->setRequired(TRUE)
    ->setTranslatable(TRUE)
    ->setRevisionable(TRUE)
    ......@@ -333,7 +332,6 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
    $fields['link'] = BaseFieldDefinition::create('link')
    ->setLabel(t('Link'))
    ->setDescription(t('The location this menu link points to.'))
    ->setRevisionable(TRUE)
    ->setRequired(TRUE)
    ->setSettings([
    ......
    ......@@ -91,7 +91,7 @@ public function testMenuLinkContentForm(): void {
    $option = $this->assertSession()->optionExists('edit-menu-parent', 'admin:');
    $this->assertTrue($option->isSelected());
    // Test that the field description is present.
    $this->assertSession()->pageTextContains('The location this menu link points to.');
    $this->assertSession()->pageTextContains('Start typing the title of a piece of content to select it. ');
    $this->submitForm([
    'title[0][value]' => 'Front page',
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment