Skip to content
Snippets Groups Projects
Commit 7b8ebdec authored by catch's avatar catch
Browse files

Issue #3205597 by Prabhat Burnwal, mherchel, Gauravmahlawat, monojithalder,...

Issue #3205597 by Prabhat Burnwal, mherchel, Gauravmahlawat, monojithalder, marcusvsouza, djsagar, kiran.kadam911, Abhijith S, vikashsoni, lauriii, Gábor Hojtsy: Olivero comment form should have title
parent 5787a570
No related branches found
No related tags found
14 merge requests!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!1896Issue #2940605: Can only intentionally re-render an entity with references 20 times,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!594Put each entity type table into a details element on admin/config/regional/content-language,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!512Issue #3207771: Menu UI node type form documentation points to non-existent function,!485Sets the autocomplete attribute for username/password input field on login form.,!449Issue #2784233: Allow multiple vocabularies in the taxonomy filter,!231Issue #2671162: summary text wysiwyg patch working fine on 9.2.0-dev,!43Resolve #3173180: Add UI for 'loading' html attribute to images,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -28,7 +28,7 @@ module.exports = {
browser
.drupalRelativeURL('/node/1')
.assert.containsText('body', 'Article without comments')
.assert.not.elementPresent(commentTitleSelector);
.assert.not.elementPresent(commentCountSelector);
},
'Article with comments should display count': (browser) => {
browser
......
......@@ -31,9 +31,14 @@
{{ attach_library('olivero/comments') }}
<section{{ attributes.setAttribute('data-drupal-selector', 'comments').addClass('comments') }}>
{% if comments and not label_hidden %}
{% if not label_hidden %}
{{ title_prefix }}
<h2{{ title_attributes.addClass('comments__title') }}>{{ label }} <span class="comments__count">{{ comment_count }}</span></h2>
<h2{{ title_attributes.addClass('comments__title') }}>
{{- label -}}
{%- if comments -%}
<span class="comments__count">{{ comment_count }}</span>
{%- endif -%}
</h2>
{{ title_suffix }}
{% endif %}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment