Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Commits
accd3516
Commit
accd3516
authored
10 years ago
by
Angie Byron
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#2285349
follow-up by effulgentsia: Cleanup to function name and code comments.
parent
2da50857
No related branches found
Branches containing commit
No related tags found
Tags containing commit
2 merge requests
!7452
Issue #1797438. HTML5 validation is preventing form submit and not fully...
,
!789
Issue #3210310: Adjust Database API to remove deprecated Drupal 9 code in Drupal 10
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
core/modules/comment/src/Tests/CommentNonNodeTest.php
+6
-5
6 additions, 5 deletions
core/modules/comment/src/Tests/CommentNonNodeTest.php
with
6 additions
and
5 deletions
core/modules/comment/src/Tests/CommentNonNodeTest.php
+
6
−
5
View file @
accd3516
...
...
@@ -422,10 +422,10 @@ function testCommentFunctionality() {
}
/**
* Tests comment fields
are not available for
entity types with
string id
s.
* Tests comment fields
cannot be added to
entity types with
out integer ID
s.
*/
public
function
tests
String
IdEntities
()
{
// Create a bundle for entity_test.
public
function
tests
NonInteger
IdEntities
()
{
// Create a bundle for entity_test
_string_id
.
entity_test_create_bundle
(
'entity_test'
,
'Entity Test'
,
'entity_test_string_id'
);
$limited_user
=
$this
->
drupalCreateUser
(
array
(
'administer entity_test_string_id fields'
,
...
...
@@ -433,16 +433,17 @@ public function testsStringIdEntities() {
$this
->
drupalLogin
(
$limited_user
);
// Visit the Field UI overview.
$this
->
drupalGet
(
'entity_test_string_id/structure/entity_test/fields'
);
// Ensure field isn't shown for
empty
IDs.
// Ensure field isn't shown for
string
IDs.
$this
->
assertNoOption
(
'edit-fields-add-new-field-type'
,
'comment'
);
// Create a bundle for entity_test_no_id.
entity_test_create_bundle
(
'entity_test'
,
'Entity Test'
,
'entity_test_no_id'
);
$this
->
drupalLogin
(
$this
->
drupalCreateUser
(
array
(
'administer entity_test_no_id fields'
,
)));
// Visit the Field UI overview.
$this
->
drupalGet
(
'entity_test_no_id/structure/entity_test/fields'
);
// Ensure field isn't shown for
string id
s.
// Ensure field isn't shown for
empty ID
s.
$this
->
assertNoOption
(
'edit-fields-add-new-field-type'
,
'comment'
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment