Issue #3165588 by longwave, mondrake: Add a check to ensure $modules property is always protected

cb0ad5b1 · catch · 1c7065df · cb0ad5b1
Commit cb0ad5b1 authored 4 years ago by catch
--- a/core/tests/Drupal/Tests/Listeners/DrupalListener.php
+++ b/core/tests/Drupal/Tests/Listeners/DrupalListener.php
@@ -96,6 +96,10 @@ public function startTest(Test $test): void {
        }
      }
    }
+    // Check for incorrect visibility of the $modules property.
+    if ($class->hasProperty('modules') && !$class->getProperty('modules')->isProtected()) {
+      @trigger_error('The ' . get_class($test) . '::$modules property must be declared protected. See https://www.drupal.org/node/2909426', E_USER_DEPRECATED);
+    }
  }

  /**