Issue #2046097 by Berdir, Gábor Hojtsy: Fixed Very long URL (>255) leads to...

Issue #2046097 by Berdir, Gábor Hojtsy: Fixed Very long URL (>255) leads to PDO exception when translation source locations are updated.

core/modules/locale/lib/Drupal/locale/StringDatabaseStorage.php

@@ -146,6 +146,8 @@ protected function updateLocation($string) {
       $created = FALSE;
       foreach ($locations as $type => $location) {
         foreach ($location as $name => $lid) {
+          // Make sure that the name isn't longer than 255 characters.
+          $name = substr($name, 0, 255);
           if (!$lid) {
             $this->dbDelete('locales_location', array('sid' => $string->getId(), 'type' => $type, 'name' => $name))
               ->execute();

core/modules/locale/lib/Drupal/locale/Tests/LocaleStringTest.php

@@ -105,6 +105,19 @@ function testStringCRUDAPI() {
     $this->assertFalse($string, 'Successfully deleted source string.');
     $deleted = $search = $this->storage->getTranslations(array('lid' => $lid));
     $this->assertFalse($deleted, 'Successfully deleted all translation strings.');
+
+    // Tests that locations of different types and arbitrary lengths can be
+    // added to a source string. Too long locations will be cut off.
+    $source_string = $this->buildSourceString();
+    $source_string->addLocation('javascript', $this->randomString(8));
+    $source_string->addLocation('configuration', $this->randomString(50));
+    $source_string->addLocation('code', $this->randomString(100));
+    $source_string->addLocation('path', $location = $this->randomString(300));
+    $source_string->save();
+
+    $rows = db_query('SELECT * FROM {locales_location} WHERE sid = :sid', array(':sid' => $source_string->lid))->fetchAllAssoc('type');
+    $this->assertEqual(count($rows), 4, '4 source locations have been persisted.');
+    $this->assertEqual($rows['path']->name, substr($location, 0, 255), 'Too long location has been limited to 255 characters.');
   }
 
   /**
@@ -166,6 +179,9 @@ function testStringSearchAPI() {
 
   /**
    * Creates random source string object.
+   *
+   * @return \Drupal\locale\StringInterface
+   *   A locale string.
    */
   function buildSourceString($values = array()) {
     return $this->storage->createString($values += array(