Skip to content
Snippets Groups Projects
Commit feca6057 authored by catch's avatar catch
Browse files

Issue #3274938 by xjm, nod_: Remove deprecated public Backbone and Underscore libraries

parent c4197f11
No related branches found
No related tags found
37 merge requests!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
# All libraries are defined in alphabetical order.
backbone:
remote: https://github.com/jashkenas/backbone
version: "1.4.0"
license:
name: MIT
url: https://raw.githubusercontent.com/jashkenas/backbone/1.4.0/LICENSE
gpl-compatible: true
js:
assets/vendor/backbone/backbone-min.js: { weight: -19, minified: true }
dependencies:
- core/underscore
deprecated: The %library_id% asset library is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0.
internal.backbone:
# Internal library. Do not depend on it outside core nor add new core usage.
# The library will be removed as soon as the following issues are fixed:
......@@ -1091,17 +1078,6 @@ tabbable.jquery.shim:
- core/tabbable
- core/jquery
underscore:
remote: https://github.com/jashkenas/underscore
version: "1.13.2"
license:
name: MIT
url: https://raw.githubusercontent.com/jashkenas/underscore/1.13.2/LICENSE
gpl-compatible: true
js:
assets/vendor/underscore/underscore-min.js: { weight: -20, minified: true }
deprecated: The %library_id% asset library is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0.
internal.underscore:
# Internal library. Do not depend on it outside core nor add new core usage.
# The library will be removed as soon as the following issues are fixed:
......
......@@ -79,10 +79,6 @@ const assetsFolder = `${coreFolder}/assets/vendor`;
library: 'internal.backbone',
files: ['backbone.js', 'backbone-min.js', 'backbone-min.map'],
},
// Only used to update the version number of the deprecated library.
{
pack: 'backbone',
},
{
pack: 'css.escape',
folder: 'css-escape',
......@@ -179,10 +175,6 @@ const assetsFolder = `${coreFolder}/assets/vendor`;
library: 'internal.underscore',
files: ['underscore-min.js', 'underscore-min.js.map'],
},
// Only used to update the version number of the deprecated library.
{
pack: 'underscore',
},
{
pack: 'loadjs',
files: [{ from: 'dist/loadjs.min.js', to: 'loadjs.min.js' }],
......
<?php
namespace Drupal\KernelTests\Core\Asset;
use Drupal\KernelTests\KernelTestBase;
/**
* Checks the deprecation status of Backbone.
*
* @group Asset
* @group legacy
*/
class DeprecatedBackboneTest extends KernelTestBase {
/**
* The library discovery service.
*
* @var \Drupal\Core\Asset\LibraryDiscoveryInterface
*/
protected $libraryDiscovery;
/**
* {@inheritdoc}
*/
protected function setUp():void {
parent::setUp();
$this->libraryDiscovery = $this->container->get('library.discovery');
}
/**
* Tests that the Backbone library is deprecated.
*/
public function testBackboneDeprecation() {
$this->libraryDiscovery->getLibraryByName('core', 'backbone');
$this->expectDeprecation("The core/backbone asset library is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0.");
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment