- Patch #8973 by JonBob: Drupal contains many undefined variables and array indices, which makes PHP throw a lot of warnings when the reporting level is set to E_ALL. Things run fine with these warnings, but as a matter of code style if nothing else we should probably strive to avoid them. The attached fixes most of the more egregious offenders (about 95% of the warnings when I load /node on my test site).

- Patch #8952 by Morbus: made the watchdog module more doxygenish:

   * @file header with a oneliner and blurb description about watchdog.module.
   * standardized the text between admin/help#watchdog and admin/logs.
   * tweaked the descriptions of log types available ever so slightly.
   * removed anything that referred to the old settings page.
   * added an assumed 'type' to one of the menu's.

- Patch #8941 by JonBob: allow local tasks to be ordered by weight, as well
  as simplifying the theming of local tasks so they can be more easily
  rendered in a non-tab manner.

- Bug #8898 by Morbus: fixed incorrect date being displayed in the forum overview when a topic has no comments yet.

- Fixing some usability bugs with aggregator admin: some forms lacked status messages, and redirected to themselves
- Now uses drupal_goto after every form submission [1]. Patches for other modules will follow.

[1] http://lists.drupal.org/archives/drupal-devel/2004-06/msg01147.html

- Preventing caching of page when status messages are present (needed for redirects after form submission to work properly)
- Double-quotes to Single-quotes

- Fixed 'pass by reference'-bug in the validation code and further simplified
  it.

$ diffstat user.patch
database/database.mysql |    4
database/database.pgsql |    2
database/updates.inc    |   10 -
modules/block.module    |   20 +-
modules/locale.module   |    9
modules/profile.module  |  108 +++++++----
modules/system.module   |    8
modules/user.module     |  456 +++++++++++++++++++-----------------------------
8 files changed, 289 insertions(+), 328 deletions(-)

More functionality, less code.  Here is a list of the changes:

- Some user API changes:
   + When $type is 'form', you have to return an associative array of groups.  In turn, each group is an array with a 'title', 'data' and 'weight'.
   + A new $type has been added, namely 'categories'.  User settings can be organized in categories.  Categories can be sorted, as can the groups within a category.  (Ordering 'categories' is somewhat broken due to a bug in the menu system.)

- The 'my account > edit' page will use subtabs for each 'category'.  Read: you can break down the account settings into multiple subpages.

- Profile module improvements:
   + Added support for private fields to the profile module!
   + Improved workflow of profile administration pages.
   + Improved the form descriptions.

- Code improvements:
   + Unified user_edit() and user_admin_edit().
   + Unified and cleaned up the validation code.  Fixed some validation glitches too.

- Tweak for sticky patch: ANSI SQL does not allow ordering on a column which is not part of the selected fields.

- Patch #8603 by TDobes: added support for sticky forum topics to the blog
  and forum module.

- Bugfix: made it possible for administrators to edit the values of custom
  profile fields of users.

- Patch #8785 by Morbus Iff (modified): with the acceptance of "anonymous-but-named" comments, anonymous users can leave behind their names as opposed to the 'anonymous' setting. These names are shown as "$name (not verified)" on regular nodes. This change provides the same display for forums (assuming anonymous commenting on forums is allowed).

- Patch #8778 by Morbus Iff: with the tabs patch, user/login, user/register, and user/password now show all three forms, as opposed to just the requested relevance. The attached patch implements a quick workaround: three new callbacks, and a cheapy modification of user_page where I use a ternary to test whether arg(2) exists (as it would in the case of user/nnn/edit). If it does, we set that to $op, and if it doesn't (in the case of user/login, etc.), we set arg(1).

- Patch #8757 by Morbus Iff: fixed redirection after comment moderation.

- Patch #8758 by Morbus Iff: allow users to modify their profile under
  the new tabs system.

- Fixed administration pages being broken due to tabs changes, improved form
  handling and form descriptions and fixed an incorrect title.

- Patch #8747 by JonBob: extended and standardized node.module Doxygen
  comments, and made formatting and quote usage more consistent.

- Fixed broken URLs in the user module (access rules) due the the recent
  tabs patch.

- Patch #8500 by jseng (modified/simplified): improved usability of editing
  URL aliases.

  correctly.