Skip to content
Snippets Groups Projects

Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with()

Closed Issue #3328457: Replace most substr($a, $i) where $i is negative with str_ends_with()
Closed Jess requested to merge issue/drupal-3328457:3328457-substr-ends into 10.1.x

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
210 210 $form_state->set('flood_control_user_identifier', $identifier);
211 211
212 // Don't allow login if the limit for this user has been reached.
213 // Default is to allow 5 failed attempts every 6 hours.
214 if (!$this->userFloodControl->isAllowed('user.failed_login_user', $flood_config->get('user_limit'), $flood_config->get('user_window'), $identifier)) {
215 $form_state->set('flood_control_triggered', 'user');
216 return;
212 // If there are zero flood records for this user, then we don't need to
213 // clear any failed login attempts after a successful login, so check
214 // for this case first before checking the actual flood limit and store
215 // the result in form state.
216 if (!$this->userFloodControl->isAllowed('user.failed_login_user', 1, $flood_config->get('user_window'), $identifier)) {
217 // Now check the actual limit for the user. Default is to allow 5
218 // failed attempts every 6 hours. This means we check the flood table
219 // twice if flood control has already been triggered by a previous
220 // login attempt, bu this should be the less common case.
  • dimitriskr added 1784 commits

    added 1784 commits

    • 05dd2404...b6aef35b - 723 commits from branch project:10.1.x
    • b6aef35b...a4d53f09 - 1051 earlier commits
    • e0e5634f - Issue #3386766 by znerol, andypost, smustgrave, xjm, catch: Add return types to SessionHandler
    • 4ca4dbaa - Issue #3328456 by xjm, dimitriskr, murilohp, smustgrave: Replace substr($a, 0,...
    • 757fd0fa - Issue #2942016 followup by andypost: Add a hook_help() to the Umami profile,...
    • 8c084d06 - Issue #2989889 by tstoeckler, idebr, joachim, bojanz, dww, alexpott: Extract...
    • 81b746b5 - Issue #3291904 by quietone, Spokje: Create a test for a dev release without a date
    • 594ab1aa - Issue #3404108 by quietone, smustgrave: Fix test performance of...
    • 30dbdff2 - Issue #3405085 by quietone, smustgrave: Fix test performance of...
    • 15ac0b4e - Issue #3363424 by _shY, vbouchet, kim.pepper, smustgrave: Use CallableResolver...
    • f3ee8975 - Use str_ends_with() in place of substr() where appropriate.
    • 914862f4 - replace substr() with str_ends_with()

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading