#3463300: Implement the concept of sections within the client
Remaining work:
-
Make end-to-end tests pass in add-section.cy.js
: issues with testing code accessing elements inside iframe -
Review and potentially revisit how preview thumbnails for the listed components and sections inPlus, this might be a good opportunity to figure out how those preview thumbnails will play nicely withListItem.tsx
are rendered. There is a failing test currently inxb-general.cy.js
that seems to be showing a real bug.overflow: scroll
added in #3463798: Unable to scroll when dragging components + unable to scroll component list. -
Add comments to explain layoutModelSlice.ts::replaceUUIDsAndUpdateModel()
andlayoutModelSlice.ts::insertMultipleNodes()
-
Implement error handling inlayoutModelSlice.ts::insertMultipleNodes()
-
Verify the use of data-xb-component-id
vs.data-xb-type
in\Drupal\experience_builder\Controller\SdcController::wrapComponentsForPreview
and in the client app -
Implement error handling inComponentList.tsx
-
Implement error handling inSectionList.tsx
-
Tidy up code in Viewport.tsx
-
Make mock data in— Let's approach this more holistically laterui/src/services/sections.ts
a bit nicer -
Add error handling around <ComponentList />
and<SectionList />
-
Nice to have: Refactor layoutModelSlice.ts::replaceUUIDsAndUpdateModel()
andlayoutModelSlice.ts::insertMultipleNodes()
, make them unit testable, then write unit tests
Edited by Bálint Kléri