Issue #3238860 by mstrelan, Theresa.Grannum, hooroomoo, bnjmnm, larowlan:...

Issue #3238860 by mstrelan, Theresa.Grannum, hooroomoo, bnjmnm, larowlan: Refactor (if feasible) use of jquery map to use vanillaJS

core/.eslintrc.jquery.json

@@ -30,7 +30,7 @@
     "jquery/no-is-function": 2,
     "jquery/no-is": 0,
     "jquery/no-load": 2,
-    "jquery/no-map": 0,
+    "jquery/no-map": 2,
     "jquery/no-merge": 2,
     "jquery/no-param": 2,
     "jquery/no-parent": 0,

core/misc/form.es6.js

@@ -157,15 +157,9 @@
    *   Array of IDs for form fields.
    */
   function fieldsList(form) {
-    const $fieldList = $(form)
-      .find('[name]')
-      .map(
-        // We use id to avoid name duplicates on radio fields and filter out
-        // elements with a name but no id.
-        (index, element) => element.getAttribute('id'),
-      );
-    // Return a true array.
-    return $.makeArray($fieldList);
+    // We use id to avoid name duplicates on radio fields and filter out
+    // elements with a name but no id.
+    return [].map.call(form.querySelectorAll('[name][id]'), (el) => el.id);
   }
 
   /**

core/misc/form.js

@@ -50,10 +50,9 @@
   }
 
   function fieldsList(form) {
-    var $fieldList = $(form).find('[name]').map(function (index, element) {
-      return element.getAttribute('id');
+    return [].map.call(form.querySelectorAll('[name][id]'), function (el) {
+      return el.id;
     });
-    return $.makeArray($fieldList);
   }
 
   Drupal.behaviors.formUpdated = {